Open
Conversation
…ensitive inputs, and removed skips from the remaining test within that describe block
…on passes all tests, including empty string and a word longer than 7 characters
…crabble object to pass all tests, likely needs major refactor, very bulking now
…logic around name attribute and edit test suite to run tests for Player constructor
…stubbed out remaining function name into the Player class
…asic logic to remaining functions in Player to test manually without test suite for now
… all tests, commented out remaining logic in methods with no written tests to try to at least simulate tdd
…call the method to debug
…were one line functions and checked and hopefully added any missing ; to the code
…of the forEach loops into one and shorten the method
JS ScrabbleWhat We're Looking For
Looks good! I'm thrilled you practiced arrow function syntax a bunch! It looks great! If I had time to refactor, I'd want to figure out a way to move away from the giant if/else if block in Otherwise good work overall |
tildeee
reviewed
May 23, 2018
| shortestIndex = index; | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
I see here you have mapped arrayOfWords into an equally-sized array of scores into scores... This means that you need to reliably work in parallel between two arrays (which is how you use index).
I haven't explored this deeply myself, but I would want to explore having an array of objects that contain a word and a score...
Just a thought for maybe a future refactoring!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS Scrabble
Congratulations! You're submitting your assignment!
Comprehension Questions