Open
Conversation
…ests for score method passing
…test to pass for the constructor.
JS ScrabbleWhat We're Looking For
|
|
|
||
| } else { | ||
| throw "Word must only contain letters from A-Z and have less than or equal to 7 characters"; | ||
| } |
There was a problem hiding this comment.
It might be a little cleaner to invert this conditional:
if (!(/^[a-zA-Z]+$/.test(word) && word.length <= 7)) {
throw new Error("Word must only contain letters from A-Z and have less than or equal to 7 characters");
}
// ... lines 11 through 20 ...|
|
||
| } else { | ||
| throw "Word must only contain letters from A-Z and have less than or equal to 7 characters"; | ||
| } |
There was a problem hiding this comment.
If you throw a regular string like you do on line 23, you don't get backtrace information! You should throw an instance of Error instead (i.e. throw new Error("Word must..."))
| const winningWord = arrayOfWords.reduce((word1, word2) => { | ||
| const scoreWord1 = Scrabble.score(word1); | ||
| const scoreWord2 = Scrabble.score(word2); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS Scrabble
Congratulations! You're submitting your assignment!
Comprehension Questions