Victoria Garcia - Ampers - JS Scrabble#37
Open
Lasiorhine wants to merge 6 commits intoAda-C9:masterfrom
Open
Conversation
…the one about ther bad characters
…ng word method, after reasonable fails.
… how the highestWordScore method is interacting with Score.
…quest time, exclamation point.
JS ScrabbleWhat We're Looking For
|
CheezItMan
reviewed
May 20, 2018
|
|
||
|
|
||
| test('returns false when score < 100', () => { | ||
| const player = new Scrabble.Player('joe'); |
There was a problem hiding this comment.
It would work better to simply loop through verifying that hashWon returns false from a score of 0 to 99. So you cover the edge cases.
|
|
||
|
|
||
| test('returns true when score == 100', () => { | ||
| const player = new Scrabble.Player('jane'); |
There was a problem hiding this comment.
You want to verify that hasWon is false at 99 and true at 100 and greater.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS Scrabble
Congratulations! You're submitting your assignment!
Comprehension Questions