Skip to content

Comments

Victoria Garcia - Ampers - JS Scrabble#37

Open
Lasiorhine wants to merge 6 commits intoAda-C9:masterfrom
Lasiorhine:master
Open

Victoria Garcia - Ampers - JS Scrabble#37
Lasiorhine wants to merge 6 commits intoAda-C9:masterfrom
Lasiorhine:master

Conversation

@Lasiorhine
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Surprisingly few. Conditionals, rough method structure, loops and arrays -- but it feels like there was far more difference than similarity.
What was a challenge you faced in this assignment? The tests, particularly, felt really impenetrable.
Do you have any recommendations on how we could improve this project for the next cohort? Uuuh, not really, right now. Too bleary.

@CheezItMan
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene You need a few more commits. Your last commit message had me chuckling.
Comprehension questions Check, hmmm.. what made the tests impenetrable?
General
score calculates score, has appropriate params and return value Check
highestScoreFrom calculates highest scoring word, has appropriate params and return value Check
Player object
Has name and plays properties Check
Has play, totalScore, hasWon functions Chekc
Has highestScoringWord and highestWordScore functions Check
Overall Well done, you hit all the learning goals for the project. I'm sorry you had a tough time of it, but glad you stuck with it.



test('returns false when score < 100', () => {
const player = new Scrabble.Player('joe');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would work better to simply loop through verifying that hashWon returns false from a score of 0 to 99. So you cover the edge cases.



test('returns true when score == 100', () => {
const player = new Scrabble.Player('jane');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to verify that hasWon is false at 99 and true at 100 and greater.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants