Ampers: Selam and Kaitlin

[kcforsman]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Trips belong to 1 Passenger and 1 Driver. A Driver can have many Trips, a Passenger can have many Trips. It eliminates the relationships by using the Trip model as a kind of joint table for Passengers and Drivers, since they only really need to know about the other in relationship with the Trip. A Passenger does not need to know its Drivers and vice versa.
Describe the role of model validations in your application	We require the presence of a Name and Phone_num for passenger and a Name and Vin for a driver with validation in their models. A rating has to be either nil of a number to be accepted (though this would only be an issue if someone malicious messed with the form.
How did your team break up the work to be done?	We did a lot of it together during project time and then assigned tasks in Trello to work on at home. We marked responsibilities by adding a member to specific notes and then (when we remembered) added both members to the tasks we completed together.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized all the rails functionality and saved all the css for the last day and a half. Also, didn't get to but set aside changing the approach to handling trips of deleted passengers or drivers (currently we just delete them).
What was one thing that your team collectively gained more clarity on after completing this assignment?	It was helpful for practicing setting up routes, MVC, and just first week of rails concepts.
What is your Trello URL?	https://trello.com/b/CQKwTdcI/rideshare-rails
What is the Heroku URL of your deployed application?	https://kf-sa-rideshare-rails.herokuapp.com/drivers/10/trips/415
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We both got to hangout with one our favorite Ada peoples and learn a lot from each other. We did good job of working on functionality goals and giving out assignments at the end of day as well as utilizing current lecture material. YAY!

[CheezItMan]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	Both partner contributed, good commit messages
Answered comprehension questions	Check, I'm glad y'all enjoyed working together
Uses named routes (like _path)	Check
RESTful routes utilized	Good that you removed unused routes
Rideshare Rails Specific Content
Table relationships	Check
Validation rules for Models	More validation in Trip would be better.
Business logic is in the models	Well done
Database is seeded from the CSV files	Check
Trello board is created and utilized in project management	Check
Postgres database is used	Check
Heroku instance is online	Check
The app is styled to create an attractive user interface	Interesting styling. I found the validation error messages hard to read. It's just not clear that's what they are immediately.
Overall	You hit all the requirements of the project. There are some small styling, validation and UI issues, but you did a good job of replicating the demonstration app. Nice work!