Ana Lisa Sutheland: Octos C9: Trek#24
Open
The-Beez-Kneez wants to merge 7 commits intoAda-C9:masterfrom
Open
Conversation
…in a list. Debating styling as I go, or all at once.
…ific occurence of trip display
… to reading values from form for iput
…eted. Clean and styling remaining, but could turn it in barebones as it is
Author
|
Still working on HTML/CSS interface. But functionality is all there. |
TREKWhat We're Looking For
|
| <!-- FIXME: Need to render the form once the trip display has activated a trip display --> | ||
| <!-- form to reserve a spot --> | ||
| <section id="spot-save"> | ||
| <h2>Reserve A Spot!</h2> |
There was a problem hiding this comment.
You might want to look into the CSS display: none for this.
| content += '<ul'; | ||
| for (const field in errors) { | ||
| for (const problem in errors[field]) { | ||
| content += `<li>${field}: ${problem}</li>` |
There was a problem hiding this comment.
Since errors[field] is an array, you probably want for (const problem of errors[field]). As is you get the indexes, not the strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TREK
Congratulations! You're submitting your assignment!
Comprehension Questions