SeeMore: BeastMaster - #13
Open
QuartzBrandi wants to merge 190 commits into
Open
Conversation
There was a problem hiding this comment.
Does this need to be an instance variable? Is it being used in the view?
…eMore into model_code_refactor/caj
|
Hey! Nice job so far. I've left a couple of comments (some of which I am seeing you address already). Please drop me a note on slack when you've had a chance to review. I'd like to meet and ask a couple of follow-up questions, plus review one or two methods that stood out to me. |
…te methods out into two separate methods.
Refactoring home controller to actually use the real model (posts)
Model code refactor/caj and profile pic parrams :D
Instagramquery/bew+caj
…eMore into favicon/bew
Favicon fix & other little things.
…eMore into beast/master
Index and specs
…eMore into refactorfun
Refactor fun part 3
…eMore into beast/master
carjug
added a commit
that referenced
this pull request
Aug 13, 2015
Adds subscription capability to instagram controller, views, etc.
|
@EliaMG @carjug @QuartzBrandi @lilagrc I merged #20 which had your week 1 code in it. This PR is now just week 2 stuff. Please update the title and description when you're done pushing code. :) |
Guard clause for private Twitter user.
…eMore into whitespace
Whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is our SeeMore project.
We don't think we have any minor bugs (we probably do, but we have squashed all bugs we ran into). One "bug" is if you're logged in to Instagram you can't follow yourself if you're a private user.
We would have liked to have gone back and done a lot of refactoring around our API calls.