Final PR for SeeMore Project - #23
Open
brittinator wants to merge 438 commits into
Open
Conversation
…ion file that had made them integers.
…te create method.
…ce the last_post_id (or the last 5 tweets if there is no last_post_id for a followee). We also created a find_twitter_params method to pull necessary API info into a hash, which we use ot Post.create.
wrote find_instagram_params, fixed name of method in call from find_twitter_params to find_instagram_params added logic to newsfeed to create variables for display for debugging
Ka/posts controller
Refactoring controllers
Subscripts/khn
…followees_helper file.
…nto ka/followee_controller_refactor
Ka/followee controller refactor
…nto github-auth/ar
GitHub auth/ar
Dev stat production gif/ar
Subscripts/khn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our site is simple and clean. We have quite a few validations to make sure the incoming data will not break the site. We also did a couple big refactors where we moved methods from the controllers and models to API helper websites.
Known issues:
Known bug from instagram: sometimes pulls 3 users from the search page as it's supposed to; other times pulls 4 users.
There may be an easter egg if you try to login to the heroic website using the developer's strategy...