Pep8 compliance and other small cosmetic improvements#3
Open
dersphere wants to merge 15 commits intoAddonScriptorDE:masterfrom
Open
Pep8 compliance and other small cosmetic improvements#3dersphere wants to merge 15 commits intoAddonScriptorDE:masterfrom
dersphere wants to merge 15 commits intoAddonScriptorDE:masterfrom
Conversation
the same result but shorter
btw, "get"-method takes fallback-value as second param, i guess you did the type comparing because you didn't wanted to put None (which will be returned by "get"-method if no fallback provided) into unquote_params. By using the fallback-value it will always return a string
Owner
|
WOW! greetings, |
|
What is the status of this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
first: you don't have to accept this one, just wanted to show how this code would look if it would be fully (except E501: line length) PEP8 compliant.
But maybe you can have a look to the last few commits, they contain some python-related improvements.