Skip to content

Conversation

gcatanese
Copy link
Contributor

@gcatanese gcatanese commented Aug 18, 2025

In this branch LEM services and models have been updated to support LEM v4.

See our documentation:

Changes

Breaking Changes 🛠

  • BusinessLine: remove capability
  • SourceOfFunds: remove acquiringBusinessLineId
  • SourceOfFunds: make adyenProcessedFunds required

Other Changes 💎

  • Individual: add support
  • Organization: add support , doingBusinessAsAbsent, registrationNumberAbsent
  • SoleProprietorship: add doingBusinessAsAbsent, registrationNumberAbsent
  • Trust: add doingBusinessAsAbsent
  • UnincorporatedPartnership: add doingBusinessAsAbsent
  • ServiceEnum: add new value"issuing"
  • SourceOfFunds: add several new attributes (amount, assetMonthsHeld, etc..)
  • SourceOfFunds: add array of Financier
  • SourceOfFunds. TypeEnum: add several new values ("employment", "donations", etc..)
  • TaxInformation: add numberAbsent
  • Document: add proofOfDirector

Testing locally

We don't have a Beta version of the library, however you can use the source code of this branch to try out the LEM v4 code.

Clone the repository and access the branch:

git clone https://github.com/Adyen/adyen-java-api-library.git
cd adyen-java-api-library
git checkout lem-v4-generation

Update the POM file to create your own version

<dependency>
   <groupId>com.adyen</groupId>
   <artifactId>adyen-java-api-library</artifactId>
   <version>39.2.0-lem-beta</version>
</dependency>

Build the library locally

mvn install

In your Java application include the 39.2.0-lem-beta jar file to try out the LEM v4 code.

@gcatanese gcatanese requested a review from a team as a code owner August 18, 2025 09:47
@gcatanese gcatanese marked this pull request as draft August 18, 2025 09:47
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request upgrades the Legal Entity Management (LEM) API integration to version 4. The update introduces several breaking changes, such as the removal of deprecated fields in BusinessLine and SourceOfFunds models, and makes adyenProcessedFunds a required field. Additionally, it significantly expands the data models with new fields across Individual, Organization, SoleProprietorship, Trust, UnincorporatedPartnership, SourceOfFunds, and TaxInformation to support richer data capture. New enumeration values have been added for business services and source of funds types, and new models like Financier and Support are introduced. The API endpoints and internal versioning have been updated accordingly to reflect the v4 specification.

Highlights

  • Breaking Change: BusinessLine Capability Removal: The 'capability' field has been removed from the BusinessLine and BusinessLineInfo models, as it was deprecated in v3.
  • Breaking Change: SourceOfFunds AcquiringBusinessLineId Removal: The 'acquiringBusinessLineId' field has been removed from the SourceOfFunds model.
  • Breaking Change: SourceOfFunds AdyenProcessedFunds Required: The 'adyenProcessedFunds' field in the SourceOfFunds model is now a required attribute.
  • New Feature: Individual Support Information: The Individual model now includes a 'support' field to capture support contact information.
  • New Feature: Organization Additional Fields: The Organization model has been enhanced with 'support', 'doingBusinessAsAbsent', and 'registrationNumberAbsent' fields.
  • New Feature: Legal Arrangement 'Doing Business As' Absence: The SoleProprietorship, Trust, and UnincorporatedPartnership models now include a 'doingBusinessAsAbsent' field.
  • New Feature: BusinessLine Service Type 'Issuing': The ServiceEnum within BusinessLine and BusinessLineInfo now includes a new 'issuing' value.
  • New Feature: Expanded SourceOfFunds Details: The SourceOfFunds model has been significantly expanded with new attributes such as 'amount', 'assetMonthsHeld', 'cryptocurrencyExchange', 'dateOfFundsReceived', 'dateOfSourceEvent', 'originatorLegalEntityId', 'purpose', 'relationship', and 'website'.
  • New Feature: SourceOfFunds Financier Details: The SourceOfFunds model now supports a list of 'Financier' objects, allowing for detailed information about third-party funding sources.
  • New Feature: Expanded SourceOfFunds Types: The TypeEnum within SourceOfFunds has been updated to include a wider range of fund types, such as 'employment', 'donations', 'inheritance', and more.
  • New Feature: Tax Information Number Absence: The TaxInformation model now includes a 'numberAbsent' field.
  • New Feature: Document Type 'Proof of Director': The Document model now supports 'proofOfDirector' as a document type.
  • API Version Upgrade: LEM v3 to v4: All API service classes and related test files have been updated to reflect the new Legal Entity Management API version 4, including constant and base URL changes.
  • Enhancement: Terms of Service Language Options: The Terms of Service acceptance and document retrieval responses now indicate support for French ('fr') language in addition to English ('en').
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Legal Entity Management API to version 4, introducing several breaking changes and new features. The changes primarily involve updates to the data models to align with the new API version, including removing deprecated fields, adding new ones, and expanding enum values. The service classes have also been updated to point to the new v4 endpoints. The changes appear to be correctly implemented based on the pull request description, with one exception noted. A field registrationNumberAbsent seems to be missing from the SoleProprietorship model, despite being mentioned in the changes list. This should be addressed to ensure full compliance with the v4 API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant