-
Notifications
You must be signed in to change notification settings - Fork 144
Release v39.4.0 #1554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Release v39.4.0 #1554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs a routine version bump for the adyen-java-api-library. Its primary purpose is to increment the library's version number to 39.3.1, reflecting the integration of recent changes, including those from merged pull request #1553. This ensures that all project files and dependencies correctly reference the latest stable release.
Highlights
- Version Update: The library version has been updated from 39.3.0 to 39.3.1 across all relevant configuration and source files.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the project version to 39.3.1
. The changes are consistent across all modified files. I've added a couple of suggestions to improve the release process by automating the version number updates in README.md
and Client.java
. By sourcing the version from a single place (pom.xml
), you can reduce manual work and prevent potential inconsistencies in future releases.
README.md
Outdated
@@ -71,7 +71,7 @@ You can use Maven and add this dependency to your project's POM: | |||
<dependency> | |||
<groupId>com.adyen</groupId> | |||
<artifactId>adyen-java-api-library</artifactId> | |||
<version>39.3.0</version> | |||
<version>39.3.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number is hardcoded in this example. This requires manual updates for each release and can lead to inconsistencies if forgotten. To improve maintainability, consider using a token here that is automatically replaced with the current version from pom.xml
during your release process. This ensures the documentation is always in sync with the released artifact.
src/main/java/com/adyen/Client.java
Outdated
@@ -10,7 +10,7 @@ public class Client { | |||
private ClientInterface httpClient; | |||
private Config config; | |||
public static final String LIB_NAME = "adyen-java-api-library"; | |||
public static final String LIB_VERSION = "39.3.0"; | |||
public static final String LIB_VERSION = "39.3.1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding the LIB_VERSION
requires manual updates for every release, which is error-prone. It's better to derive this value from the pom.xml
, which should be the single source of truth. You can achieve this by having Maven filter a properties file (e.g., src/main/resources/version.properties
containing version=${project.version}
) and then loading that property in this class. This would ensure LIB_VERSION
is always consistent with the Maven project version and simplify your release process.
56d7203
to
b06de84
Compare
b06de84
to
8febf34
Compare
Merged pull requests to be released:
Full Changelog: v39.3.0...main