-
Notifications
You must be signed in to change notification settings - Fork 6
Revamp #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed TopologyButtonsView to CutoutAccessoryView throughout the codebase for clarity and consistency. Updated all usages, documentation, and previews. Also removed the redundant NotchMyProblemClass.swift file, consolidating its contents into NotchMyProblem.swift.
Introduces the CutoutAccessoryPadding enum to allow .auto, .none, or custom padding for the cutout and content areas in CutoutAccessoryView. Updates the view's layout logic to use the selected padding configuration and enhances documentation and previews to demonstrate the new options.
Expanded documentation for CutoutAccessoryView, including detailed explanations and examples for the new `padding` parameter and its customization. Clarified override mechanisms, precedence, and advanced usage. Improved formatting, added rationale for padding, and updated compatibility, logging, and contribution sections for clarity and completeness.
Removed detailed explanation of the CutoutAccessoryView padding parameter for brevity and added new contact and social links at the end of the README.
Introduced shields.io badges to display Swift version, iOS compatibility, and license information in the README for improved project visibility.
Updated the default exclusionWidth fallback to use 30% of the view width if unavailable. Modified padding logic to apply content padding only when a top cutout is present, and simplified the condition for rendering the cutout space.
Updated the `.auto` mode to use new default padding values for cutout, content, and vertical padding. Also set the font of leading and trailing content overlays to `.footnote` for improved appearance. Updated README to reflect the simplified description of `.auto` mode.
Increased the default exclusion width fallback from 30% to 40% of the view width and reduced the fallback frame height from 40 to 30 when there is no top cutout. These changes refine the layout for better visual alignment.
Introduces a workflow to build and test the Swift package on iOS using Swift 6.0 and Xcode on macOS runners. The workflow runs on push and pull requests to main, supports both debug and release configurations, and dynamically selects an available iOS simulator.
Aeastr
commented
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.