Fixes #6
Merged
Fixes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refines the `.auto` padding mode in CutoutAccessoryView to use an inverse relationship between cutout width and padding, ensuring better spacing across device types. Updates the README to clarify the new padding logic. Adds an override for modelID iPhone17,5 device in NotchMyProblem.swift. Includes a new preview for iOS 26 in CutoutAccessoryView.swift.
Extracted top padding logic into a separate variable for clarity and added section comments to improve code readability. No functional changes were made to the layout behavior ! ! !
Adjusted the fallback exclusion width for non-cutout devices from 160 to 180 for improved layout. Updated the description text for adaptive padding behavior. Removed the Photos Example preview code for iOS 26.
Owner
Author
|
huzzah, should probably add better examples tho |
Revised README for clarity and improved section organization. Updated several asset images and removed unused Post.png and Post2x.jpeg files.
Rewrote the 'Overrides' section in the README for clarity, replaced HTML with Markdown image syntax, and updated the notchError.png asset. Also removed redundant sections to streamline documentation.
Replaces Capsule-based leading and trailing content in CutoutAccessoryView examples with Button views using a new notchMyProblem_Example_Button view modifier. Adds the modifier to style buttons consistently and support highlighted states, improving code clarity and reusability.
Changed the comment in the View extension to indicate support for iOS 13 instead of iOS 14. Added a note about improving examples in the future.
Owner
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fucked up some of the rewrite so fixing it asap