Conversation
…settings (v1.18.0) Co-authored-by: Aedankerr <56336929+Aedankerr@users.noreply.github.com>
…agement feat: multi-site management foundation + Uptime Kuma integration (v1.18.0)
Co-authored-by: Aedankerr <56336929+Aedankerr@users.noreply.github.com>
Add funny comment to server.js
Co-authored-by: Aedankerr <56336929+Aedankerr@users.noreply.github.com>
…dev-build Add comment to Dockerfile builder stage
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e274b3960
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| kuma_url: document.getElementById('settingKumaUrl').value.replace(/\/$/, ''), | ||
| kuma_api_key: document.getElementById('settingKumaApiKey').value, | ||
| }, |
There was a problem hiding this comment.
This writes kuma_api_key into site_settings through /api/site, but the public read-only server exposes all site_settings keys via unauthenticated GET /api/site (src/server.js, publicApp.get('/api/site')). In any deployment where the public app is reachable, the Kuma API key becomes publicly retrievable, so this introduces a credential leak rather than protected configuration storage.
Useful? React with 👍 / 👎.
| const { name, description, type, visibility, status, custom_domain, public_url, | ||
| monitoring_enabled, monitoring_url, monitoring_interval, monitoring_ssl_check } = req.body; |
There was a problem hiding this comment.
The edit modal submits slug for existing sites, but the update handler does not read or update slug, so a slug change appears to save successfully while the database keeps the old value. This is a silent mismatch between UI and API behavior that will confuse admins and leave stale slugs unless they delete/recreate the site.
Useful? React with 👍 / 👎.
.