Feat/settings page revamp by Annieeeee11 · Pull Request #2797 · AgentWrapper/agent-orchestrator

Annieeeee11 · 2026-07-18T12:45:44Z

Summary

Rebuild Global Settings to the Figma layout: General (theme + Connect Mobile), Updates, and Get help → Feedback, with shared settings primitives and tokens
Route sidebar Settings straight to /settings, move Feedback / Connect Mobile / theme out of the sidebar menu into Settings
Add Light / Dark / System theme preference with live OS sync when System is selected; auto-save update channel toggles (no Save button)
Restyle Connect Mobile + Report a problem dialogs, unify modal/sheet overlays with a shared blurred scrim
Revamp Report a problem: Title + “What happened?” fields, segmented radio picker for GitHub / Discord / Email, footer with Cancel + destination action, keyboard shortcuts (Esc / ⌘·Ctrl+Enter), auto-focus title on open, submit disabled until both fields are filled
Fix settings-route shell layout: hide topbar on settings, keep Windows sidebar below the titlebar strip, single sidebar toggle on Windows/Linux (no duplicate trigger)
Remove the standalone /prs board (PRs stay in the session inspector); stop mounting the first-run MigrationPopup on home while keeping MigrationSection for a later Settings integration

Intentional omissions

Connect with us (LinkedIn / Twitter social links) is commented out for now — code kept in place to re-enable later
Migration is not re-added to Settings in this PR (MigrationSection remains available to wire later)
No replacement global PR surface; session inspector remains the desktop PR entry point

Test plan

Sidebar Settings → /settings: close returns home; topbar hidden on settings routes
Windows: settings sidebar sits below titlebar; one sidebar toggle (no duplicate in sidebar header)
Theme Light / Dark / System persists; System follows OS appearance changes
Updates: enable/disable + channel auto-save, nightly warning, check / download / install still work
Connect Mobile from Settings: enable, QR/password, regenerate
Feedback: Title + “What happened?” → GitHub / Discord / Email via radio picker; drafts redact local paths/URLs/secrets; correct destinations open; Cancel / Esc closes; ⌘·Ctrl+Enter submits; submit disabled when fields empty
Connect with us section is not shown in Settings
/prs is gone; session inspector still lists stacked PRs
Fresh launch no longer shows MigrationPopup

Before

After

Replace the settings cards with a Figma-aligned settings layout (theme, Connect Mobile, updates, feedback), move sidebar entry points into Settings, and drop the standalone /prs board in favor of session inspector PRs.

Vaibhaav-Tiwari

Settings page may break on Windows
The new Settings page hides the topbar, but the sidebar can move up and cover the Windows title/menu bar.
Secret scanning was weakened too much
The PR allowlists whole files in gitleaks just because of a LinkedIn false positive. That could hide real secrets later.
Docs still mention /prs
The PR removes the /prs page, but the public docs still tell users to open /prs.
Global Settings telemetry is incomplete
The new /settings route is reported as other instead of something like global_settings.

Drop whole-file gitleaks allowlists, document /settings instead of /prs, and report /settings as global_settings.

Vaibhaav-Tiwari

On Windows, the new Settings page may let the sidebar overlap the custom title/menu bar.

codebanditssss

i tested the new settings page and related flows in the linux desktop app and everything is working nicely. i also reviewed the theme handling, updates, connect mobile, feedback flow, sidebar changes, and removal of the standalone pr page. the code looks clean and the relevant tests are passing. approved.

Offset the sidebar under the WindowTitlebar on settings and drop the duplicate collapsed-rail expand control.

Replace the separate header expand/collapse triggers with one SidebarTrigger so the rail no longer shows duplicate controls.

Vaibhaav-Tiwari

lgtm now
just resolve prettier and will merge

i-trytoohard · 2026-07-19T19:31:25Z

From the NotesBot call on 2026-07-19, this existing pr appears to be relevant.
Match confidence: 0.94 (fuzzy).

Relevant discussion excerpts:

- Started exploring custom loops earlier but paused when learning harshitsingh had parallel work; design doc already shared with prateek. - harshitsingh clarified custom loops work was exploratory on a fork; “significant progress,” but not ready to present yet; agreed to align via design doc review first [...]
- Anaya: working on two PRs: “settings page revamp” + “design page”; incorporating prateek’s suggestions. - Previously joined last Sunday; created a bug-fix PR “in the tracker intake.” - .phylolver(vaibhaav): “session timeline… will be better in the redesign,” but prateek reiterated not to wait for redesign for [...]
- harshitsingh clarified custom loops work was exploratory on a fork; “significant progress,” but not ready to present yet; agreed to align via design doc review first (prateek: “start with design doc”). - Anaya: working on two PRs: “settings page revamp” + “design page”; incorporating prateek’s suggestions.

Source thread: https://discord.com/channels/1476302178913357958/1528463891200217212/1528463891200217212

Generated by AO Bot based on the transcript from NotesBot.

Redesign Report a problem with radio destination picker, footer actions, and Cmd/Ctrl+Enter submit; temporarily comment out the Connect with us social links section until those URLs are ready.

Update placeholder expectation and re-enter title before the email destination flow, since submit clears fields and disables until title is filled.

Align sidebar, titlebar chrome, and settings frame to #1E1F22, set the center panel to #101013, and darken settings rows to #18181C.

…revamp

Annieeeee11 · 2026-07-20T22:41:18Z

@iamasx @whoisasx

Co-authored-by: Cursor <cursoragent@cursor.com>

Annieeeee11 added 3 commits July 18, 2026 18:03

feat: revamp global settings page and remove PR board

c4c38ba

Replace the settings cards with a Figma-aligned settings layout (theme, Connect Mobile, updates, feedback), move sidebar entry points into Settings, and drop the standalone /prs board in favor of session inspector PRs.

test: drop PullRequestsPage coverage from PR hydration suite

752876e

fix: polish Report a problem dialog spacing and title size

13701f2

Annieeeee11 requested a review from Vaibhaav-Tiwari July 18, 2026 12:45

Annieeeee11 self-assigned this Jul 18, 2026

Annieeeee11 added 5 commits July 18, 2026 18:19

fix: add warning icon to Nightly updates notice

903ec93

Merge branch 'main' into feat/settings-page-revamp

5f24d6f

chore: format settings UI files with Prettier

d505908

fix: allowlist LinkedIn company URL and extract settings social links

7361328

chore: fix Prettier formatting in _shell.tsx

ad57041

Annieeeee11 requested a review from codebanditssss July 18, 2026 16:39

Annieeeee11 added 2 commits July 18, 2026 22:11

fix: avoid LinkedIn gitleaks false positive in settings test

d1d4092

fix: allowlist settings social-link test for LinkedIn false positives

09ef0e1

Annieeeee11 requested a review from JAYATIAHUJA July 18, 2026 20:20

Vaibhaav-Tiwari requested changes Jul 18, 2026

View reviewed changes

fix: address settings-revamp review on docs, telemetry, and gitleaks

4b65be8

Drop whole-file gitleaks allowlists, document /settings instead of /prs, and report /settings as global_settings.

Vaibhaav-Tiwari requested changes Jul 19, 2026

View reviewed changes

codebanditssss approved these changes Jul 19, 2026

View reviewed changes

Annieeeee11 added 2 commits July 19, 2026 15:58

fix: keep Windows settings sidebar clear of the titlebar

4e0bbd3

Offset the sidebar under the WindowTitlebar on settings and drop the duplicate collapsed-rail expand control.

fix: use a single sidebar toggle on Windows and Linux

8d3f05c

Replace the separate header expand/collapse triggers with one SidebarTrigger so the rail no longer shows duplicate controls.

Vaibhaav-Tiwari approved these changes Jul 19, 2026

View reviewed changes

Annieeeee11 added 5 commits July 20, 2026 17:59

feat: revamp feedback dialog and hide Connect with us

f829765

Redesign Report a problem with radio destination picker, footer actions, and Cmd/Ctrl+Enter submit; temporarily comment out the Connect with us social links section until those URLs are ready.

test: fix feedback dialog tests after form clear-on-submit

c5fecfe

Update placeholder expectation and re-enter title before the email destination flow, since submit clears fields and disables until title is filled.

fix: retune settings chrome and row surfaces

4cf8ecd

Align sidebar, titlebar chrome, and settings frame to #1E1F22, set the center panel to #101013, and darken settings rows to #18181C.

fix: drop keyboard shortcut hint from feedback dialog footer

9de1e5a

Merge remote-tracking branch 'upstream/main' into feat/settings-page-…

f20b044

…revamp

Annieeeee11 and others added 2 commits July 21, 2026 04:12

chore: format UpdatesSection and tokens after merge

c91824a

Co-authored-by: Cursor <cursoragent@cursor.com>

fix: tune sidebar bg token to #17181C

58043a0

chore: format sidebar bg token for Prettier

7bfc93c

Co-authored-by: Cursor <cursoragent@cursor.com>

Annieeeee11 merged commit 689e2dc into main Jul 21, 2026
5 checks passed

Annieeeee11 deleted the feat/settings-page-revamp branch July 21, 2026 10:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/settings page revamp#2797

Feat/settings page revamp#2797
Annieeeee11 merged 21 commits into
mainfrom
feat/settings-page-revamp

Annieeeee11 commented Jul 18, 2026 •

edited

Loading

Uh oh!

Vaibhaav-Tiwari left a comment

Uh oh!

Vaibhaav-Tiwari left a comment •

edited

Loading

Uh oh!

codebanditssss left a comment

Uh oh!

Vaibhaav-Tiwari left a comment

Uh oh!

i-trytoohard commented Jul 19, 2026

Uh oh!

Annieeeee11 commented Jul 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Annieeeee11 commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Intentional omissions

Test plan

Before

After

Uh oh!

Vaibhaav-Tiwari left a comment

Choose a reason for hiding this comment

Uh oh!

Vaibhaav-Tiwari left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codebanditssss left a comment

Choose a reason for hiding this comment

Uh oh!

Vaibhaav-Tiwari left a comment

Choose a reason for hiding this comment

Uh oh!

i-trytoohard commented Jul 19, 2026

Uh oh!

Annieeeee11 commented Jul 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Annieeeee11 commented Jul 18, 2026 •

edited

Loading

Vaibhaav-Tiwari left a comment •

edited

Loading