fix: expose PR activity timing#2841
Open
whoisasx wants to merge 1 commit into
Open
Conversation
whoisasx
force-pushed
the
ao/reverb-2/issue-2835-pr-activity
branch
2 times, most recently
from
July 19, 2026 14:45
5250417 to
500e15c
Compare
whoisasx
marked this pull request as ready for review
July 19, 2026 14:53
Collaborator
Author
|
Visual evidence for the right-sidebar PR activity changes, captured with Playwright from the mock Summary rail Pull Requests card: verifies the PR state chips size to their content; the Activity timeline: verifies PR activity entries render as clickable links with visible state timestamps. The hovered |
illegalcall
reviewed
Jul 19, 2026
illegalcall
left a comment
Collaborator
There was a problem hiding this comment.
Timestamp correctness still has three gaps; inline comments identify the exact paths. The Badge note is non-blocking scope feedback.
whoisasx
force-pushed
the
ao/reverb-2/issue-2835-pr-activity
branch
2 times, most recently
from
July 21, 2026 14:02
584964a to
e137421
Compare
whoisasx
force-pushed
the
ao/reverb-2/issue-2835-pr-activity
branch
from
July 21, 2026 14:08
e137421 to
38bca5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
stateChangedAtfor PR summaries, including migration/sqlc/OpenAPI/frontend schema updates.draft/state labels size to content in the Summary rail and PR list.RCA
The malformed
draftchip came from the sharedBadgebase class usingsize-icon-xl, which fixed both width and height to the icon token. PR state badges overrode height withh-5but still inherited the fixed 18px width, so the text overflowed outside the painted badge. The affected surfaces were the Summary rail PR card and the PR list page. Activity timeline rows, review labels, dashboard/session cards, and sidebar rows do not use that same fixed-width badge treatment.Verification
npm run sqlcnpm run apicd backend && go test ./internal/httpd/... ./internal/service/session ./internal/storage/sqlite/storenpm --prefix frontend run test -- SessionInspector.test.tsx badge.test.tsxnpm --prefix frontend run typecheckgit diff --checkcd backend && test -z "$(gofmt -l internal/domain/pr.go internal/httpd/controllers/dto.go internal/httpd/controllers/sessions_test.go internal/service/session/pr_summary.go internal/service/session/service_test.go internal/storage/sqlite/store/pr_facts_test.go internal/storage/sqlite/store/pr_store.go internal/storage/sqlite/store/store_test.go)"npm --prefix frontend run dev:web -- --host 127.0.0.1,ao preview http://127.0.0.1:5173/, and Playwright DOM measurements for Summary rail Activity links and Badge widths.Omitted
npm --prefix frontend run buildis not available infrontend/package.json(Missing script: "build").Closes #2835