Skip to content

fix: remove duplicate sidebar header trigger #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Vaibhaav-Tiwari wants to merge 2 commits into from
+6 −12
Closed

fix: remove duplicate sidebar header trigger #2842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19238f3
fix: remove duplicate sidebar header trigger
Jul 19, 2026
387606d
chore: format sidebar header fix
Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions frontend/src/renderer/components/Sidebar.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,6 +863,12 @@ describe("Sidebar", () => {
expect(projectRow).toHaveClass("pr-sidebar-project-actions");
});

it("does not render a duplicate collapse trigger in the expanded header", () => {
renderSidebar();

expect(screen.queryByRole("button", { name: "Collapse sidebar" })).not.toBeInTheDocument();
});

it("snaps to the real collapsed rail when dragged past the resize collapse threshold", async () => {
renderSidebar();

Expand Down
12 changes: 0 additions & 12 deletions frontend/src/renderer/components/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,18 +262,6 @@ export function Sidebar({
nightly
</span>
)}
{/* On macOS the toggle lives in the titlebar cluster instead. */}
{!isMac && (
<Tooltip>
<TooltipTrigger asChild>
<SidebarTrigger
aria-label="Collapse sidebar"
className="sidebar-expanded-chrome size-icon-xl shrink-0 rounded-sm p-0 text-passive hover:bg-interactive-hover hover:text-foreground group-data-[collapsible=icon]:hidden [&_svg]:size-icon-lg"
/>
</TooltipTrigger>
<TooltipContent>Collapse sidebar · ⌘B</TooltipContent>
</Tooltip>
)}
</div>
</SidebarHeader>

Expand Down
Loading