fix(frontend): make dev:web cross-platform using cross-env#2995
Open
ronishrohan wants to merge 1 commit into
Open
fix(frontend): make dev:web cross-platform using cross-env#2995ronishrohan wants to merge 1 commit into
ronishrohan wants to merge 1 commit into
Conversation
VITE_NO_ELECTRON=1 fails on Windows (PowerShell/cmd) because inline env var assignment is a Unix-only shell feature. Prefix the command with cross-env so the variable is set portably on all platforms. Closes AgentWrapper#2981
Collaborator
|
Thanks for contributing to Agent Orchestrator. This PR is being picked up by the current external contributor on-call pair: If someone is already working on this, please continue as usual. For faster context or live questions, you can also join the AO Discord. Join the session here: Come by if you want to see what is being built, ask questions, or just hang around with the community. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run dev:webuses inline Unix env assignment (VITE_NO_ELECTRON=1 vite ...), which fails on Windows (PowerShell/cmd). This blocks Windows contributors from running the web preview.Changes
cross-envas a dev dependency (^10.1.0)dev:webscript to prefix withcross-env:cross-envis the standard solution for this — it normalises env var setting across shells with no behaviour change on macOS/Linux.Verification
npm run typecheck✓cross-envis a zero-dependency, widely-used package (hundreds of millions of weekly downloads)Closes #2981