feat: add pre-commit hooks for formatting and linting#993
Merged
Yunusabdul38 merged 1 commit intoJun 30, 2026
Conversation
- Add .pre-commit-config.yaml with hooks for rustfmt, cargo clippy, prettier (v3.1.0), and eslint - Add .github/workflows/pre-commit.yml CI step that runs pre-commit run --all-files on push/PR to main and develop - Document setup in DEVELOPMENT_SETUP.md (section 11)
|
@Abba073 is attempting to deploy a commit to the oseh-svg's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Abba073 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Yunusabdul38
approved these changes
Jun 30, 2026
Yunusabdul38
left a comment
Yunusabdul38
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thanks for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #956
Adds pre-commit hooks to enforce code formatting and linting at commit time, preventing unformatted code from reaching CI.
Changes
.pre-commit-config.yaml— defines hooks for:pre-commit-hooks: trailing whitespace, EOF fixer, merge-conflict detectorrustfmt(local):cargo fmt --all -- --checkcargo clippy(local):--all-targets --all-features -D warningsprettier(mirrors-prettier v3.1.0): JS/TS/CSS/JSON/MD fileseslint(local via pnpm):pnpm --filter web lint.github/workflows/pre-commit.yml— CI job that runspre-commit run --all-fileson every push/PR tomainanddevelopDEVELOPMENT_SETUP.md— added section 11 documenting install, activation, hook table, manual run, auto-fix, and skip instructionsHow to activate locally
From then on, every
git commitwill run the hooks automatically.Acceptance Criteria