Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps cleanup #10922

Merged
merged 2 commits into from
Feb 3, 2025
Merged

deps cleanup #10922

merged 2 commits into from
Feb 3, 2025

Conversation

turadg
Copy link
Member

@turadg turadg commented Jan 31, 2025

evergreen

Description

See clean commits

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

@turadg turadg requested a review from Muneeb147 January 31, 2025 19:33
Copy link

cloudflare-workers-and-pages bot commented Jan 31, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ef71b3
Status: ✅  Deploy successful!
Preview URL: https://75016fa7.agoric-sdk.pages.dev
Branch Preview URL: https://ta-cleanup.agoric-sdk.pages.dev

View logs

@turadg turadg marked this pull request as ready for review January 31, 2025 21:47
@turadg turadg requested a review from a team as a code owner January 31, 2025 21:47
Copy link
Contributor

@Muneeb147 Muneeb147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an ongoing effort of deps cleanup for all packages? Or we are we just concerned for agoric-cli atm?

@turadg
Copy link
Member Author

turadg commented Feb 1, 2025

Is there an ongoing effort of deps cleanup for all packages? Or we are we just concerned for agoric-cli atm?

I just noticed these while looking during SnT. The LLM presentation made me check out mutable.ai we had, but that business closed up shop and didn't tell anyone. So I removed this badge. Then I looked for other dead things to remove.

I consider cleaning a regular activity to do to keep a codebase healthy, like weeding.

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Feb 3, 2025
Copy link
Contributor

mergify bot commented Feb 3, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Feb 3, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Feb 3, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot merged commit 473abf9 into master Feb 3, 2025
83 checks passed
@mergify mergify bot deleted the ta/cleanup branch February 3, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants