Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Stop leaking kernel promises from EV.sendOnly calls #10943

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

gibson042
Copy link
Member

Fixes #10942

Description

Sets result policy "ignore" in EV.sendOnly calls to prevent kpid allocation.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

This code is itself a testing utility.

Upgrade Considerations

n/a

@gibson042 gibson042 requested review from mhofman and dckc February 4, 2025 20:49
@gibson042 gibson042 requested a review from a team as a code owner February 4, 2025 20:49
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks plausible

I haven't tested it yet. I can test it before you merge if you want to stand by for a bit.

Copy link

cloudflare-workers-and-pages bot commented Feb 4, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: ca93a9b
Status: ✅  Deploy successful!
Preview URL: https://972f55a0.agoric-sdk.pages.dev
Branch Preview URL: https://gibson-10942-ev-sendonly.agoric-sdk.pages.dev

View logs

Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh didn't realize we had another place to stand to inject this.

@gibson042 gibson042 added the automerge:rebase Automatically rebase updates, then merge label Feb 5, 2025
@gibson042 gibson042 force-pushed the gibson-10942-ev-sendonly branch from 6d8d5cf to ca93a9b Compare February 5, 2025 00:34
Copy link
Contributor

mergify bot commented Feb 5, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot merged commit 3a87731 into master Feb 5, 2025
83 checks passed
@mergify mergify bot deleted the gibson-10942-ev-sendonly branch February 5, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EV.sendOnly leaks kernel promises
3 participants