test(fast-usdc): test restart contract during long tx

[samsiegart]

closes #10898
refs #10948

Description

• Adds a contract restart to the middle advance bootstrap test
• Enhances the existing restart test to change the feeConfig and verify changes in vstorage

Testing Considerations

Figured it was easier to just reuse the existing test case.

Upgrade Considerations

Gives us confidence that contract still functions during upgrade

[turadg]

Nice and clean. This got me thinking about another coverage we need.

[turadg]

The change above is good. I think as a matter of course we should name this test in each suite so it's clear that it's tested.

So please leave this here (with incarnationNumber: 2 and a comment as to why)

A bit ouf of scope but I think we also here should verify that not only does the contract keep working (as above) but things that are expected to change on restart do. I.e. feeConfig in the private args should show up in vstorage. (see writes fee config to vstorage test).

Please add that to this PR or make a separate issue to do that.

[samsiegart]

Made an issue #10948

I'll do that as part of this PR then re-request review

[samsiegart]

PTAL

[cloudflare-workers-and-pages]

Deploying agoric-sdk with    Cloudflare Pages

Latest commit:	6a37552
Status:	✅  Deploy successful!
Preview URL:	https://3934abd2.agoric-sdk.pages.dev
Branch Preview URL:	https://test-fu-restart.agoric-sdk.pages.dev

View logs

[samsiegart]

I'm using documentStorageSchema because the remotable brands don't seem to play well with deepEqual

[turadg]

Worthwhile to write the snapshot but please first verify that storage has the new feeConfig.

[samsiegart]

I tried:

  t.deepEqual(
    storage
      .getValues(`published.fastUsdc.feeConfig`)
      .map(defaultSerializer.parse)
      .at(-1),
    {
      flat: newFlat,
      variableRate: newVariableRate,
      contractRate: newContractRate,
    },
  );

And get:

Difference (- actual, + expected):

    {
      contractRate: {
        denominator: {
          brand: Object @Alleged: USDC brand {
  +         getKref: Function getKref {},
  +         iface: Function iface {},
          },
          value: 11n,
        },

I'm sure there's ways around it but I don't know why we'd need to clutter the test with that when the snapshot works fine. We can verify the snapshot in code review the same as we'd verify the assertion in the .ts file, and the test will fail the same way if it changes.

[turadg]

You can filter out brand.

why we'd need to clutter the test with that when the snapshot works fine

The snapshot is for detecting changes. The assertion here should be that the values being put in come back out.

I'm sure there's ways around it

Yes. For one you could filter out brand. We have work planned to make that unnecessary,

• identity-preserving marshallers for vstorage testing, clients etc. #10491

So if for now you want to leave a comment, I'll approve.

// XXX verify manually that the new feeConfig above appears in the snapshot
// UNTIL https://github.com/Agoric/agoric-sdk/issues/10491