fix: remove --break-system-packages silent fallback in install.sh#19
Open
xiaolai wants to merge 1 commit into
Open
fix: remove --break-system-packages silent fallback in install.sh#19xiaolai wants to merge 1 commit into
xiaolai wants to merge 1 commit into
Conversation
Silent fallback to --break-system-packages can corrupt system Python packages without explicit user consent. Replace with a clear failure message and virtual environment guidance. Co-Authored-By: Claude Code <noreply@anthropic.com>
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
install.shlines 70–76 silently fall back topip install --break-system-packageswhen the standardpip installfails. This flag bypasses pip's protection for system-managed Python environments, which can corrupt system packages without the user's knowledge or consent.On modern Linux distros (Debian 12+, Ubuntu 23.04+, Fedora 38+), system Python is externally managed. The
--break-system-packagesflag exists for explicit opt-in, not as a transparent fallback.Fix
Replace the silent fallback with a clear failure message and virtual environment guidance, consistent with the script's existing error-surfacing pattern (e.g. the
pip not foundbranch on line 78 already does this correctly).Before
After
Users who need the global install can still do it explicitly — the failure message tells them how.