fix(install): point REPO_URL at this repo + unmute clone errors#39
Open
reikjarloekl wants to merge 1 commit into
Open
fix(install): point REPO_URL at this repo + unmute clone errors#39reikjarloekl wants to merge 1 commit into
reikjarloekl wants to merge 1 commit into
Conversation
…one errors install.sh's REPO_URL still pointed at https://github.com/AI-Marketing-Hub/claude-ads, which no longer resolves ("Repository not found"). That made `bash install.sh` fail with exit 128 for everyone whose Dockerfile/script does the documented two-step (clone this repo + run install.sh), because install.sh re-clones the repo from REPO_URL rather than reusing the already-cloned checkout. Also drop `2>/dev/null` on the clone — it was what masked the real "Repository not found" message and made the failure look like a generic exit 128 with no explanation. Errors on this line are always actionable; they belong on stderr. Verified end-to-end in a clean debian:bookworm-slim container: install completes with exit 0 and lays down all 22 sub-skills and 10 agents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.sh'sREPO_URLstill pointed athttps://github.com/AI-Marketing-Hub/claude-ads, which no longer resolves. Anyone runningbash install.sh(including via the documented "clone + bash install.sh" pattern) currently hits a silentexit 128.REPO_URLto point athttps://github.com/AgriciDaniel/claude-ads.2>/dev/nullon the clone — that's what hid the underlyingremote: Repository not found.message and made the failure look like a generic git error with no explanation. Errors on this line are always actionable and belong on stderr.Reproduction (before this PR)
With
2>/dev/nullremoved, the real error becomes visible:After this PR
Verified end-to-end in a clean
debian:bookworm-slimcontainer —install.shcompletes with exit 0 and lays down all 22 sub-skills and 10 agents.Test plan
bash install.shsucceeds in a fresh container with onlygit+ca-certificatesinstall.sh; no behavior change to any other target/path