Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for copilot models #3273

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nhs000
Copy link

@nhs000 nhs000 commented Feb 17, 2025

solve #2227

Wait for BerriAI/litellm#8577 to be merged

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2025

CLA assistant check
All committers have signed the CLA.

@nhs000 nhs000 changed the title feat: add support for copilot models WIP feat: add support for copilot models Feb 17, 2025
@nhs000 nhs000 marked this pull request as draft February 18, 2025 14:34
@beetleb
Copy link

beetleb commented Mar 7, 2025

I think for the claude models, we should keep haiku as the weak models. Having sonnet-3.5 as the weak model for sonnet-3.7 is expensive and overkill.

@nhs000 nhs000 force-pushed the feat/add_copilot branch from 87f60ba to a1286d0 Compare March 8, 2025 07:19
@nhs000 nhs000 marked this pull request as ready for review March 8, 2025 07:21
@nhs000
Copy link
Author

nhs000 commented Mar 8, 2025

@paul-gauthier Since the changes in litellm side were merged at BerriAI/litellm#8577, could you have a look at this to see if I'm missing anythings?
I think the remaining is to bump litellm version once it is merged to the main branch and officially released.
Also I saw some warnings about missing the model information, I guess we need to fix it in litellm side as well?

@nhs000 nhs000 changed the title WIP feat: add support for copilot models feat: add support for copilot models Mar 8, 2025
@beetleb
Copy link

beetleb commented Mar 8, 2025

I think for the claude models, we should keep haiku as the weak models. Having sonnet-3.5 as the weak model for sonnet-3.7 is expensive and overkill.

@nhs000

Please change the weak models to haiku. sonnet-3.5 costs the same as sonnet-3.7 - there's no point in making 3.5 the weaker model.

@necto
Copy link

necto commented Mar 8, 2025

Please change the weak models to haiku. sonnet-3.5 costs the same as sonnet-3.7 - there's no point in making 3.5 the weaker model.

Sorry to intrude here, are the sonnet costs relevant when used via GH Copilot? Isn't it a flat fee regardless of the model used?

@beetleb
Copy link

beetleb commented Mar 8, 2025

Please change the weak models to haiku. sonnet-3.5 costs the same as sonnet-3.7 - there's no point in making 3.5 the weaker model.

Sorry to intrude here, are the sonnet costs relevant when used via GH Copilot? Isn't it a flat fee regardless of the model used?

Fair point. One could even argue that the weak model could be the same as the strong model in that case - why have them be different?

My concern is twofold.

The first is simple: Using such a heavy model is overkill for the weak model.

The second is that (some) people who have used proxies to reroute Aider to copilot have gotten warning emails from Microsoft. It's not clear what triggers it - perhaps too much /architect use. I think that lowering the overall burden on their servers would make it less likely to be banned from Copilot. As such, using a much "lighter" model for the weak model makes sense.

use_repo_map: true
examples_as_sys_msg: true
extra_params:
max_tokens: 8192
Copy link

@TheBestPessimist TheBestPessimist Mar 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the number of tokens so small? As far as i see both 3.7 and 3.5 accept 200k context: https://docs.anthropic.com/en/docs/about-claude/models/all-models.

do I misunderstand how max_tokens works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants