feat(tips,indexer): tip status lifecycle, cursor pagination, DTO serializer, indexer cursor tests#1087
Merged
Akanimoh12 merged 10 commits intoJun 29, 2026
Conversation
|
@bade2brazy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
f36d5e8 to
ae452c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #880
Closes #881
Closes #886
Closes #892
Summary
cursor.test.ts(unit tests forgetCursorLedger/setCursorLedger) andprojections.test.ts(idempotency fixtures proving re-running over the same ledger range produces no duplicate rows)tips.dto.ts(TipResponseDtointerface) andtips.serializer.ts(serializeTippure function converting BigInt→string, Date→ISO 8601, addsstatusfield); refactorstips.service.tsto use the serializer throughout; newtips.serializer.test.tswith 7 unit testsconfirmTip(txHash)service function (PENDING→CONFIRMED, idempotent),confirmTipParamSchema,confirmcontroller, andPATCH /tips/:txHash/confirmroute with OpenAPI spec entrynextCursorfrom page 1 is forwarded to Prisma as{ cursor: { id }, skip: 1 }on page 2), non-cuid cursor rejection, and last-page null-cursor assertionsTest plan
cursor.test.ts— get null when no row, get stored ledger, upsert shape, idempotent writes, monotonic advanceprojections.test.ts— new event persisted + Tip upserted, duplicate event log skipped on replay, Tip upsert still fires (no-op), non-tip topics skip Tip upsert, unparseable value handled gracefully,tipalias treated same astip_senttips.serializer.test.ts— BigInt→string, Date→ISO, status/message fieldstips.test.ts— confirm 404 (not found), 200 PENDING→CONFIRMED (callsupdate), 200 idempotent on CONFIRMED (skipsupdate), cursor chain page 1→2 passes correct Prisma args, non-cuid cursor returns 400, last-pagenextCursoris null