Add custom card outline highlighting and registry system#129
Draft
BAKAOLC wants to merge 1 commit intoAlchyr:developfrom
Draft
Add custom card outline highlighting and registry system#129BAKAOLC wants to merge 1 commit intoAlchyr:developfrom
BAKAOLC wants to merge 1 commit intoAlchyr:developfrom
Conversation
- Introduced ModCardHandOutlinePatchHelper for applying custom highlights to cards in hand. - Created ModCardHandOutlineRegistry to manage outline rules for different card types. - Implemented ModCardHandOutlineRule struct to define outline properties. - Added Harmony patches to NHandCardHolder for updating card outlines and flashing effects based on custom rules.
Contributor
Author
|
ritsulib will use the data from this branch for data handoff work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new extensible system for customizing the outline color of hand cards in combat, allowing both local and foreign (cross-mod) rules to control the highlight color and visibility. The system is modular, supports priority-based rule selection, and integrates with the game's update and flash methods via Harmony patches.
Custom Hand Card Outline System
ModCardHandOutlineRuleas a record struct to encapsulate outline color, activation condition, priority, and visibility behavior.ModCardHandOutlinePatchHelperfor evaluating and applying outline rules to card holders, including both highlight and flash effects.Integration with Game Logic
NHandCardHolder.UpdateCardandNHandCardHolder.Flashusing Harmony to apply the custom outline logic after vanilla behavior, ensuring modded outlines are visible during card updates and flashes.Extensibility & Testing