[Obscura Tooltips] Fix lang path for rarity for 3 languages + added missing rarity post-candy update#1591
Open
Shibva wants to merge 4 commits intoAlexModGuy:mainfrom
Open
[Obscura Tooltips] Fix lang path for rarity for 3 languages + added missing rarity post-candy update#1591Shibva wants to merge 4 commits intoAlexModGuy:mainfrom
Shibva wants to merge 4 commits intoAlexModGuy:mainfrom
Conversation
Due to how the lang was created for the rarity, a : has to be used to properly point to it. Should fix AlexModGuy#1580 Also added sweet tooltip since it was missing
Contributor
|
Hello, the zh_tw file has been repaired. Thanks for your reminder. I hope you can delete the zh_tw part in this merged project, because I have made a lot of repairs on this translation file. Thanks again! |
Contributor
|
|
Author
|
Unsure how todo that; maybe if you send a merge request to my branch here I can apply it and it will override the changes I made in this one? |
Contributor
|
|
Contributor
|
So can you remove the zh_tw part of this RP? |
Contributor
|
🤓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to how the lang string for the rarities was implemented, a
:has to be used betweenrarity.alexscavesand[rarityname].namefor it to work.So instead of
rarity.alexscaves.rainbow.name, it has to berarity.alexscaves:rainbow.namedue to the path having a:instead of a.needs to be applied to the other lang files that have it, I have corrected for
en_us,ko_kr, andzh_tw(kr and tw need translation to be confirmed correct)Also added
"rarity.alexscaves:sweet.name": "Sweet"as it was not implemented in that major update (also added rainbow and sweet toko_krusing DeepL (Translation needs verification)This merge is not necessary if the path for the internal name of the rarity is corrected
Resolves #1580 for 3 languages
(Remade request due to pull request being made to merge with wrong branch on personal fork; OOPS)