1.21.1 neoforge bug fix #1698
Open
1.21.1 neoforge bug fix #1698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll for improved clarity
…a slowdown during use
…s; update spawn rules for various entities to utilize new logic
…s hurt when affected
…maBlock to enhance block behavior
… FissurePrimalMagmaBlock and PrimalMagmaBlock
…ity IDs are runtime values
…d distance for accuracy
…bItem for improved clarity and efficiency
…streamline entity movement handling
…on logic and ensure proper damage checks
…enger movement accuracy
…enhance gameplay dynamics
…andardize item behavior
…allTorch to check for water source type
…tag for exclusive_with_relentless_darkness
…eplace reflection with direct checks for jumping state
…taMessage; replace automatic sync from 1.20
- Updated rendertype_irradiated shaders to include fog parameters and discard low alpha fragments. - Enhanced rendertype_purple_witch shaders with fog effects and optimized color calculations. - Modified rendertype_red_ghost shaders to incorporate fog and improved color blending. - Updated rendertype_sepia shaders to support fog and refined color processing. - Introduced new blit and blur shader programs for post-processing effects. - Added bumpy shader program for a distortion effect with time-based animation. - Refactored shader JSON configurations to include new uniforms and samplers. - Cleaned up unnecessary light direction uniforms from multiple shader files.
…ters - Updated shineOriginVertex, shineLeftCornerVertex, and shineRightCornerVertex methods across multiple renderers to eliminate the unused Matrix3f normal parameter. - Simplified vertex addition calls in ConversionCrucibleBlockRenderer, HologramProjectorBlockRenderer, SirenLightBlockRenderer, MineGuardianRenderer, NotorRenderer, NucleeperRenderer, RaycatRenderer, and SubmarineRenderer. - Improved code readability and maintainability by streamlining the rendering logic.
…ormance and compatibility with version 1.21
…for consistency; update rendertype_sepia shader to improve performance and remove unused variables
…sage to ensure proper server synchronization
…vior; update goal registration in SubterranodonEntity
…balance; add new exclusive tags for related enchantments
…ed gameplay diversity
…t duration and expiration between server and client
…SHAIR for RidingMeterMount and DarknessArmorItem
…reation; update handleCameraServerSide method to support distant viewing of BeholderEyeEntity
…andling; remove unused constructor and clean up imports
…d rider positioning calculations
…ng when attached to an entity
…update Beholder sync handling and improve effect visuality message processing
…nd introduce return-to-ground logic; update gravity behavior and dismount positioning
…fter leaping; update stuck state detection logic
…ent incorrect biome color and state persistence
There was a problem hiding this comment.
Pull request overview
This PR addresses a comprehensive set of bug fixes for the Alex's Caves mod's migration from Minecraft 1.20 to 1.21.1 NeoForge. The update resolves critical crashes, rendering issues, mob behaviors, enchantment conflicts, multiplayer synchronization problems, and various gameplay mechanics across all cave biomes.
Changes:
- Fixed 50+ crashes and disconnects related to spawn eggs, ray guns, block interactions, nuclear explosions, and riding entities
- Corrected mob AI, aquatic mob drowning, drops/loot tables, and riding behavior
- Restored magnetic system, enchantment mutual exclusivity, shader compatibility, and various rendering effects
- Implemented proper data synchronization for multiplayer (bubbled effects, magnetic data, beholder camera)
- Migrated to 1.21 APIs: data maps for compostables, custom spawn placements, enchantment exclusive sets, attachment-based entity data
Reviewed changes
Copilot reviewed 161 out of 161 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Data maps & tags | Migrated compostables to data map system, added breathing underwater tags, enchantment exclusivity |
| Shader files | Updated shader uniforms (InSize/OutSize), fixed post-processing passes for watcher blur, submarine light |
| Entity classes | Fixed GumWorm riding/return-to-ground logic, collisions, Subterranodon attack AI, spawn rules |
| Item classes | Fixed arrow constructors, ink bombs, biome treats, primitive club stun stacking, enchantment checks |
| Potion effects | Migrated Deepsight to per-entity tracking, Bubbled to client-side visual system |
| Network messages | Added UpdateMagneticDataMessage, enhanced BeholderSyncMessage with position data |
| Block entities | Fixed ConversionCrucible surface rules, Gobthumper worm tracking, magma block ticking |
| Mixins | Added CorrodentCollisionMixin, updated EntityMixin for magnetic sync, LocalPlayerMixin for Galena Gauntlet |
| Renderers | Fixed vertex consumers for 1.21 API changes, color packing order, Dreadbow pull state |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/github/alexmodguy/alexscaves/server/recipe/RecipeCaveMap.java
Show resolved
Hide resolved
src/main/java/com/github/alexmodguy/alexscaves/server/entity/item/SodaBottleRocketEntity.java
Show resolved
Hide resolved
src/main/java/com/github/alexmodguy/alexscaves/server/entity/item/SodaBottleRocketEntity.java
Show resolved
Hide resolved
src/main/java/com/github/alexmodguy/alexscaves/server/entity/item/SodaBottleRocketEntity.java
Show resolved
Hide resolved
…thods in SodaBottleRocketEntity for enhanced functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated Bug Fix Summary (All Issues Resolved)
This update consolidates and resolves all previously reported issues across gameplay, rendering, items, mobs, enchantments, UI, and multiplayer stability.
All problems listed below have been confirmed fixed.
Some renderer effects and Gumworm/Gobthumper riding behavior were restored on a best-effort basis due to major API changes.
A few undocumented behaviors that could be considered bugs were also fixed (e.g. biome conversion crucible locking to the first lollipop).
Happy to iterate further.
1. Crashes & Disconnects (Critical)
Fixed player disconnects when:
Fixed Creative Mode spawn egg for Tremorzilla not spawning the entity
Fixed right-clicking magnetic / hologram related blocks causing crashes
2. Mob Behavior & Survival Logic
Fixed aquatic mobs drowning:
Fixed Raycat glow, radiation visuals, and drops
Fixed Gamma Cockroach not releasing toxic gas on damage
Fixed Watcher mind-control ending without moth-face jumpscare
Fixed Gumworm and Gobthumper riding / movement issues
Fixed Candy Unicorn missing Sweet Puff drop
Fixed Tremorzilla egg not hatching after nuclear overload explosion
Fixed players not being attacked after stepping on Pterosaur eggs
Fixed Sky Titan (Gigantic creature) screen shake missing near player and while riding
3. Drops & Loot Tables
Fixed incorrect drops:
Corrected gelatin source:
Fixed Raycat missing documented drops (book & encyclopedia)
Fixed Uranium / Nuclear related mobs dropping incorrect or missing loot
4. Blocks, Mining & World Interaction
Fixed mining logic:
Fixed acid interaction with copper blocks:
Fixed Cave Stone Slabs & Manuscripts all sharing same color
Fixed two cave structures spawning too close together
Fixed nuclear bomb fall damage not triggering explosion
5. Magnetism System
Restored magnetic behavior:
Fixed Magnetized Slime Ball brewing issue
Fixed extended-duration magnetism potions not brewing correctly
Fixed Magnetic Quarry Crusher interactions
6. Items & Weapons
Fixed Ray Gun:
Fixed Ink Bomb & Glow Ink Bomb not throwing or exploding
Fixed Purple Soda Bottle Rocket:
Fixed Ice Mint Candy freezing damage bypassing leather armor
Fixed Primal Club agility enchantment not reducing cooldown
Fixed Nuclear Warning Light crafting recipe
Fixed seating height on nuclear bomb & submarine
Fixed submarine camera jitter and incorrect POV
7. Enchantments (Mutual Exclusivity)
Enchantment conflicts are now enforced correctly:
Fixed Dread Bow icon bug after storing enchanted bow
Fixed Bubble Prison enchantment lasting permanently instead of 10 seconds
8. Status Effects & Potions
Fixed Abyssal Vision potion (8 min normal & splash) having no effect
Fixed Radiation:
Fixed Sugar Rush behavior (working as intended)
Fixed all Candy items not restoring hunger properly
Fixed unbound Biome Lollipop not being edible
9. Rendering & Visual Effects (No Shaders)
Fixed missing visuals without shaders:
Fixed scanner beam & teleport obelisk beams hiding fluids
Fixed hologram projector not displaying scanned entities or player model
Fixed Neodymium visuals & magnet VFX
10. Books, UI & Localization
Fixed:
Fixed Alex’s Mobs & mod books being excessively dark
11. Multiplayer & Progression
12. Miscellaneous
Fixed:
Final Status
✅ All known issues have been integrated and resolved
Special Thanks
Huge thanks to our testers for the extensive and high-quality testing effort, covering gameplay, visuals, mechanics, and multiplayer edge cases across multiple versions.
GitHub: https://github.com/LUCK666DUCK
Discord: Josu (ID: 938188956586102854)
GitHub: Jose Sancho: https://github.com/jsanchoa