Repository navigation
docs(compatibility): document remaining extension gaps - #320
Merged
Merged
Conversation
List the extension gaps that have no generic fix: sandbox pages served with the extension pages' policy, use_dynamic_url, the favicon permission, chrome_settings_overrides, setUninstallURL, the static rule count, DNR exclusions and initiatorDomains with ports, the partial chrome.devtools surface, global commands, inspector connections starting devtools pages, webRequest details, JavaScriptCore engine gaps and the 1Password desktop app step. Add a WebKitGapTests case for sandbox pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the extension gaps that have no generic fix in Lilo, each checked against Lilo's code and WebKit's sources:
sandbox.pagesare served like other extension pages, with theextension_pagesCSP andchrome.*, soevalandnew Functionare refused there (new WEBKIT-GAPS entry 103 and aWebKitGapTestscase; the CSP is not widened).web_accessible_resources.use_dynamic_urlis ignored.chrome_settings_overridesand thefaviconpermission (_favicon/URLs).setUninstallURLsucceeds and does nothing.getAvailableStaticRuleCountalways answers 30000; exclusions compile toignore-following-rulesthat also cancel the extension's later rules (WEBKIT-GAPS 104);initiatorDomainsmiss frames whose URL names a port (WEBKIT-GAPS 105).chrome.devtoolslacks, in COMPATIBILITY.md andchrome-surface-gaps.txt(not probed byChromeSurfaceTests, which still checks COMPATIBILITY.md names them). An inspector Lilo connects without showing it (chrome.debugger, agent tools) starts every extension'sdevtools_page."global": trueworks only while Lilo is active;commandsleaves the "Supported as in Chrome" list.initiator,frameTypeordocumentLifecycle, status-text-onlystatusLine, localizederror.Temporal, iterator helpers, version-floor gaps,Date.parseformats, webkit.org/b/242740,Error.prepareStackTrace), no polyfill.Upstream WebKit reports are worth filing for the sandbox pages' CSP,
use_dynamic_url, DNR exclusion rules andinitiatorDomainswith ports; none is filed here.Testing
make swift-test SWIFT_TEST_FILTER="LiloTests/WebKitGapTests LiloTests/ChromeSurfaceTests": passes, including the newtestSandboxPagesGetTheExtensionPagesPolicyAndAPIs.make swiftlint: no violations.jscon macOS 27.2.