Removing ADTs and Parser Exports Due to Too Much Internals Exposure #959
+24
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #958. In my last Catlab PR, I added the ADTs and Parser modules to Catlab. The end goal was to provide the user with access to the relation string macro and AlgebraicJulia developers with PEG rules when they explicitly import them in other packages. However, many unneeded items were exported, leaving basic users with too much access to internals. This PR modifies this such that basic users can only access the Relation string macro with a typical
Using Catlab. Otherwise, they will need to explicitly callUsing Catlab.Parsersto gain access to specific PEG-building constructs. Minor fixes were made on top of this. For instance, the "collect()" function within ParserCore.jl was renamed to create clarity between the ParserCore feature and the Base Julia function.