semester_tasks #13

Stargazer2005 · 2024-10-04T15:09:34Z

topology sort algorithm (further will be extended to package manger simulating prorgram)

(have some issues with packman algo)

github-actions

clang-tidy made some suggestions

github-actions · 2024-10-30T21:07:16Z

task_01/src/test.cpp

+
+  dg_1.AddDirEdge(0, 1);
+
+  PackageManager packman_1(dg_1);


warning: variable 'packman_1' of type 'PackageManager' can be declared 'const' [misc-const-correctness]

Suggested change

PackageManager packman_1(dg_1);

PackageManager const packman_1(dg_1);

github-actions · 2024-10-30T21:07:16Z

task_01/src/test.cpp

+
+  dg_2.AddDirEdge(0, 1);
+
+  PackageManager packman_2(dg_2);


warning: variable 'packman_2' of type 'PackageManager' can be declared 'const' [misc-const-correctness]

Suggested change

PackageManager packman_2(dg_2);

PackageManager const packman_2(dg_2);

github-actions · 2024-10-30T21:07:16Z

task_01/src/test.cpp

+  dg_3.AddDirEdge(2, 3);
+  dg_3.AddDirEdge(3, 4);
+
+  PackageManager packman_3(dg_3);


warning: variable 'packman_3' of type 'PackageManager' can be declared 'const' [misc-const-correctness]

Suggested change

PackageManager packman_3(dg_3);

PackageManager const packman_3(dg_3);

github-actions · 2024-10-30T21:07:16Z

task_01/src/test.cpp

+  dg_4.AddDirEdge(4, 6);
+  dg_4.AddDirEdge(5, 7);
+  dg_4.AddDirEdge(6, 7);
+  PackageManager packman_4(dg_4);


warning: variable 'packman_4' of type 'PackageManager' can be declared 'const' [misc-const-correctness]

Suggested change

PackageManager packman_4(dg_4);

PackageManager const packman_4(dg_4);

github-actions

clang-tidy made some suggestions

github-actions · 2024-10-31T12:59:42Z

task_01/src/test.cpp

+
+  dg_1.AddDirEdge(0, 1);
+
+  PackageManager packman_1(dg_1);


warning: variable 'packman_1' of type 'PackageManager' can be declared 'const' [misc-const-correctness]

Suggested change

PackageManager packman_1(dg_1);

PackageManager const packman_1(dg_1);

github-actions · 2024-10-31T12:59:42Z

task_01/src/test.cpp

+
+  dg_2.AddDirEdge(0, 1);
+
+  PackageManager packman_2(dg_2);


warning: variable 'packman_2' of type 'PackageManager' can be declared 'const' [misc-const-correctness]

Suggested change

PackageManager packman_2(dg_2);

PackageManager const packman_2(dg_2);

github-actions · 2024-10-31T12:59:42Z

task_01/src/test.cpp

+  dg_3.AddDirEdge(2, 3);
+  dg_3.AddDirEdge(3, 4);
+
+  PackageManager packman_3(dg_3);


warning: variable 'packman_3' of type 'PackageManager' can be declared 'const' [misc-const-correctness]

Suggested change

PackageManager packman_3(dg_3);

PackageManager const packman_3(dg_3);

github-actions · 2024-10-31T12:59:42Z

task_01/src/test.cpp

+  dg_4.AddDirEdge(4, 6);
+  dg_4.AddDirEdge(5, 7);
+  dg_4.AddDirEdge(6, 7);
+  PackageManager packman_4(dg_4);


warning: variable 'packman_4' of type 'PackageManager' can be declared 'const' [misc-const-correctness]

Suggested change

PackageManager packman_4(dg_4);

PackageManager const packman_4(dg_4);

github-actions

clang-tidy made some suggestions

github-actions · 2024-10-31T13:54:54Z

lib/src/graph.hpp

+  }
+
+ protected:
+  std::vector<std::shared_ptr<Vertex<T>>> vertices_;


warning: member variable 'vertices_' has protected visibility [cppcoreguidelines-non-private-member-variables-in-classes]

std::vector<std::shared_ptr<Vertex<T>>> vertices_; ^

github-actions · 2024-10-31T13:54:55Z

task_01/src/test.cpp

+
+  dg_1.AddDirEdge(0, 1);
+
+  PackageManager packman_1(dg_1);


warning: variable 'packman_1' of type 'PackageManager' can be declared 'const' [misc-const-correctness]

Suggested change

PackageManager packman_1(dg_1);

PackageManager const packman_1(dg_1);

github-actions · 2024-10-31T13:54:55Z

task_01/src/test.cpp

+
+  dg_2.AddDirEdge(0, 1);
+
+  PackageManager packman_2(dg_2);


warning: variable 'packman_2' of type 'PackageManager' can be declared 'const' [misc-const-correctness]

Suggested change

PackageManager packman_2(dg_2);

PackageManager const packman_2(dg_2);

github-actions · 2024-10-31T13:54:55Z

task_01/src/test.cpp

+  dg_3.AddDirEdge(2, 3);
+  dg_3.AddDirEdge(3, 4);
+
+  PackageManager packman_3(dg_3);


warning: variable 'packman_3' of type 'PackageManager' can be declared 'const' [misc-const-correctness]

Suggested change

PackageManager packman_3(dg_3);

PackageManager const packman_3(dg_3);

github-actions · 2024-10-31T13:54:55Z

task_01/src/test.cpp

+  dg_4.AddDirEdge(4, 6);
+  dg_4.AddDirEdge(5, 7);
+  dg_4.AddDirEdge(6, 7);
+  PackageManager packman_4(dg_4);


warning: variable 'packman_4' of type 'PackageManager' can be declared 'const' [misc-const-correctness]

Suggested change

PackageManager packman_4(dg_4);

PackageManager const packman_4(dg_4);

.github/workflows/clang-tidy-review.yaml

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 40. Check the log or trigger a new build to see more.

github-actions · 2025-01-15T18:02:04Z

lib/src/graph.hpp

+};
+
+template <typename T, typename VT>
+concept IsVertex = std::is_base_of<Vertex<VT>, T>::value;


warning: unknown type name 'concept' [clang-diagnostic-error]

concept IsVertex = std::is_base_of<Vertex<VT>, T>::value; ^

github-actions · 2025-01-15T18:02:04Z

lib/src/graph.hpp

+/// @tparam VertexType
+/// @tparam T
+template <typename VertexType, typename T>
+  requires IsVertex<VertexType, T>


warning: expected ';' at end of declaration [clang-diagnostic-error]

Suggested change

requires IsVertex<VertexType, T>

requires IsVertex<VertexType, T>;

github-actions · 2025-01-15T18:02:04Z

lib/src/graph.hpp

+/// @tparam VertexType
+/// @tparam T
+template <typename VertexType, typename T>
+  requires IsVertex<VertexType, T>


warning: unknown type name 'requires' [clang-diagnostic-error]

requires IsVertex<VertexType, T> ^

github-actions · 2025-01-15T18:02:04Z

lib/src/graph.hpp

+/// @tparam VertexType
+/// @tparam T
+template <typename VertexType, typename T>
+  requires IsVertex<VertexType, T>


warning: variable template partial specialization does not specialize any template argument; to define the primary template, remove the template argument list [clang-diagnostic-error]

Suggested change

requires IsVertex<VertexType, T>

requires IsVertex

github-actions · 2025-01-15T18:02:04Z

lib/src/graph.hpp

+/// @tparam T
+template <typename VertexType, typename T>
+  requires IsVertex<VertexType, T>
+class Graph {


warning: constructor does not initialize these fields: vertices_ [cppcoreguidelines-pro-type-member-init]

lib/src/graph.hpp:209:

- std::vector<std::shared_ptr<VertexType>> vertices_; + std::vector<std::shared_ptr<VertexType>> vertices_{};

github-actions · 2025-01-15T18:02:05Z

lib/src/graph.hpp

+   * @param vertex
+   * @return size_t
+   */
+  size_t Find(const T &vertex) const {


warning: unknown type name 'T' [clang-diagnostic-error]

size_t Find(const T &vertex) const { ^

github-actions · 2025-01-15T18:02:05Z

lib/src/graph.hpp

+   * Remove a vertex from the graph
+   * @param vertex
+   */
+  virtual void RemoveVertex(std::shared_ptr<VertexType> vertex) {


warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]

virtual void RemoveVertex(std::shared_ptr<VertexType> vertex) { ^

github-actions · 2025-01-15T18:02:05Z

lib/src/graph.hpp

+   * @param source
+   * @param target
+   */
+  virtual void AddDirEdge(std::shared_ptr<VertexType> source,


warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]

virtual void AddDirEdge(std::shared_ptr<VertexType> source, ^

github-actions · 2025-01-15T18:02:05Z

lib/src/graph.hpp

+   * @param target
+   */
+  virtual void AddDirEdge(std::shared_ptr<VertexType> source,
+                          std::shared_ptr<VertexType> target) {


warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]

std::shared_ptr<VertexType> target) { ^

github-actions · 2025-01-15T18:02:05Z

lib/src/graph.hpp

+   * @param source
+   * @param target
+   */
+  virtual void RemoveDirEdge(std::shared_ptr<VertexType> source,


warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]

virtual void RemoveDirEdge(std::shared_ptr<VertexType> source, ^

Stargazer2005 added 20 commits September 21, 2024 19:56

Add graph class in utils

f0bd3c8

Undirected edge adding func

1d846ff

Rename files

d3602f6

Graph class improvement

22ffad7

Return utils files

3709d12

Move methods definitions to the header

e3e497c

Improve naming

75d57fa

Task_01 classes

0c36f3e

Improve methods naming

3fe4cd4

Add Size() method

22d90b8

Disacard changes

e1ce917

task_01 packman alogirthm

310e284

Add indices methods

4eb21cb

Output impovment

c84a76b

Fomat

e2f2f28

Topology sort algorithm + tests

7a6280a

(have some issues with packman algo)

resolve conflict

4f1a34d

Merge branch 'main' into main

4246f4b

Merge branch 'AlgorithmsDafeMipt2024:main' into main

8c0bdf5

Merge branch 'AlgorithmsDafeMipt2024:main' into main

faa6e67

github-actions bot reviewed Oct 30, 2024

View reviewed changes

Stargazer2005 added 2 commits October 31, 2024 12:49

codestyle improvement

d545794

apply some clang-tidy suggestions

d4966ea

github-actions bot reviewed Oct 31, 2024

View reviewed changes

task_02

6aa324c

Stargazer2005 changed the title ~~task_01~~ semestr_tasks Oct 31, 2024

Stargazer2005 changed the title ~~semestr_tasks~~ semester_tasks Oct 31, 2024

github-actions bot reviewed Oct 31, 2024

View reviewed changes

Stargazer2005 added 2 commits October 31, 2024 14:27

made function return beridges and cut vertices, fixed tests due to this

474f6a6

add missing '#pragma once'

158b669

AlgorithmsDafeMipt2024 deleted a comment from github-actions bot Jan 14, 2025

LostPointer requested changes Jan 14, 2025

View reviewed changes

.github/workflows/clang-tidy-review.yaml Outdated Show resolved Hide resolved

bring missing clang-tidy configs back

cdb6dd5

github-actions bot reviewed Jan 15, 2025

View reviewed changes

Stargazer2005 requested a review from LostPointer January 15, 2025 18:04

	PackageManager packman_1(dg_1);
	PackageManager const packman_1(dg_1);

	PackageManager packman_2(dg_2);
	PackageManager const packman_2(dg_2);

	PackageManager packman_3(dg_3);
	PackageManager const packman_3(dg_3);

	PackageManager packman_4(dg_4);
	PackageManager const packman_4(dg_4);

	requires IsVertex<VertexType, T>
	requires IsVertex<VertexType, T>;

semester_tasks #13

Are you sure you want to change the base?

semester_tasks #13

Uh oh!

Conversation

Stargazer2005 commented Oct 4, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!