Merge users (additional task) #28
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include <string> | ||
| #include <vector> | ||
|
|
||
| #include "graph.hpp" |
There was a problem hiding this comment.
warning: 'graph.hpp' file not found [clang-diagnostic-error]
#include "graph.hpp"
^| #include "graph.hpp" | ||
|
|
||
| /// @brief Type of user data | ||
| enum Type { Name, Email }; |
There was a problem hiding this comment.
warning: enum 'Type' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]
enum Type { Name, Email };
^|
|
||
| /// @brief User with a name and email | ||
| struct User { | ||
| User(const std::string& name, const std::set<std::string>& emails) |
There was a problem hiding this comment.
warning: constructor does not initialize these fields: emails [cppcoreguidelines-pro-type-member-init]
additional_tasks/merge_users/src/merge_users.hpp:31:
- std::set<std::string> emails; // set to avoid duplicates
+ std::set<std::string> emails{}; // set to avoid duplicates| }; | ||
|
|
||
| template <typename T, typename VT> | ||
| concept IsVertex = std::is_base_of<Vertex<VT>, T>::value; |
There was a problem hiding this comment.
warning: unknown type name 'concept' [clang-diagnostic-error]
concept IsVertex = std::is_base_of<Vertex<VT>, T>::value;
^| /// @tparam VertexType | ||
| /// @tparam T | ||
| template <typename VertexType, typename T> | ||
| requires IsVertex<VertexType, T> |
There was a problem hiding this comment.
warning: expected ';' at end of declaration [clang-diagnostic-error]
| requires IsVertex<VertexType, T> | |
| requires IsVertex<VertexType, T>; |
| * @param data | ||
| */ | ||
| virtual void AddVertex(const T &data) { | ||
| vertices_.push_back(std::make_shared<VertexType>(data)); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]
vertices_.push_back(std::make_shared<VertexType>(data));
^| vertices_.push_back(std::make_shared<VertexType>(data)); | ||
| }; | ||
|
|
||
| std::shared_ptr<VertexType> operator[](size_t index) { |
There was a problem hiding this comment.
warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]
std::shared_ptr<VertexType> operator[](size_t index) {
^| return vertices_[index]; | ||
| } | ||
|
|
||
| const std::shared_ptr<VertexType> operator[](size_t index) const { |
There was a problem hiding this comment.
warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]
const std::shared_ptr<VertexType> operator[](size_t index) const {
^| * @param vertex | ||
| * @return size_t | ||
| */ | ||
| size_t Find(const T &vertex) const { |
There was a problem hiding this comment.
warning: unknown type name 'T' [clang-diagnostic-error]
size_t Find(const T &vertex) const {
^| * Remove a vertex from the graph | ||
| * @param vertex | ||
| */ | ||
| virtual void RemoveVertex(std::shared_ptr<VertexType> vertex) { |
There was a problem hiding this comment.
warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]
virtual void RemoveVertex(std::shared_ptr<VertexType> vertex) {
^
No description provided.