-
Notifications
You must be signed in to change notification settings - Fork 23
Nasedkin Ivan's tasks #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 15 out of 71. Check the log or trigger a new build to see more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 15 out of 68. Check the log or trigger a new build to see more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 15 out of 60. Check the log or trigger a new build to see more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 15 out of 55. Check the log or trigger a new build to see more.
std::vector<double> BellmanFordAlgorithm(const WeightedGraph& graph, | ||
int start_id) { | ||
int n = graph.GetVerts(); | ||
std::vector<double> pathLength(n, DBL_MAX); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
не по кодстайлу( path_length правильно, ни и везде
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
имена файлов должны быть в стиле переменных, а расширение hpp( bellman_ford.hpp
pathLength[start_id] = 0; | ||
int this_id = start_id; | ||
int counter = 0; | ||
for (; true;) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
тогда уж for (;;)
@@ -0,0 +1,31 @@ | |||
#include <GraphDFSIterator.h> | |||
|
|||
GraphDFSIterator::GraphDFSIterator(const WeightedGraph* const graph, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
красивее было бы вот так:
GraphDFSIterator::GraphDFSIterator(...) : start_id(start_id), graph(),... {}
TEST(TopologicalSortTest, Simple) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
тестов бы побольше(
No description provided.