Kulikov Maksimilian #35

MoxDevl · 2025-01-16T20:42:51Z

Куликов Максимилиан
Б03-312

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-16T20:46:23Z

task_03/src/bell_john.hpp

@@ -0,0 +1,8 @@
+#include "dijkstra.hpp"


warning: 'dijkstra.hpp' file not found [clang-diagnostic-error]

#include "dijkstra.hpp" ^

github-actions

clang-tidy made some suggestions

github-actions

clang-tidy made some suggestions

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-16T22:00:57Z

lib/src/util.cpp

@@ -1 +1,45 @@
 #include "util.hpp"
+
+EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {


warning: the parameter 'edges' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

lib/src/util.hpp:12:

- EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges); + EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges);

Suggested change

EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {

EdgeOrientedGraph::EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges) {

LostPointer

нет тестов, и задач, и код стайл не тот(
и форматирование не то(

LostPointer · 2025-01-16T22:42:53Z

task_01/src/topo.cpp

не экономь на именах

LostPointer · 2025-01-16T22:43:02Z

task_01/src/topo.cpp

@@ -0,0 +1,33 @@
+#include "topo.hpp"
+
+void topo_recr(EdgeOrientedGraph& graph, std::stack<int>& vstack, std::vector<int>& vcolor, int current) {


не по код стайлу(

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 18. Check the log or trigger a new build to see more.

github-actions · 2025-01-16T23:07:55Z

lib/src/util.cpp

@@ -1 +1,45 @@
 #include "util.hpp"
+
+EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {


warning: the parameter 'edges' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

lib/src/util.hpp:12:

- EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges); + EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges);

Suggested change

EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {

EdgeOrientedGraph::EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges) {

github-actions · 2025-01-16T23:07:55Z

lib/src/util.cpp

+
+EdgeOrientedGraph::EdgeOrientedGraph(EdgeOrientedGraph const& graph) : _ways(graph._ways) {}
+
+int EdgeOrientedGraph::size() { return _ways.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int EdgeOrientedGraph::size() { return _ways.size(); } ^

github-actions · 2025-01-16T23:07:55Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int V = weights.size(); ^

github-actions · 2025-01-16T23:07:55Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: variable 'V' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int V = weights.size();

int const V = weights.size();

github-actions · 2025-01-16T23:07:55Z

lib/src/util.cpp

+        x.pop_back();
+}
+
+int OrientedWeightedGraph::size() { return _weights.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int OrientedWeightedGraph::size() { return _weights.size(); } ^

github-actions · 2025-01-16T23:07:56Z

task_04/src/test.cpp

+TEST(Dijkstra, Simple) {
+  std::vector<double> expected = {0., 7., 9., 20., 20., 11.};
+
+  double inf = std::numeric_limits<double>::infinity();


warning: variable 'inf' of type 'double' can be declared 'const' [misc-const-correctness]

Suggested change

double inf = std::numeric_limits<double>::infinity();

double const inf = std::numeric_limits<double>::infinity();

github-actions · 2025-01-16T23:07:57Z

task_05/src/rmq.hpp

+#include <cmath>
+
+template<class Comparator>
+std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) {


warning: the parameter 'vals' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) { ^

github-actions · 2025-01-16T23:07:57Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) {
+    int K = static_cast<int>(std::log2(vals.size()))+1;


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(vals.size()))+1;

int const K = static_cast<int>(std::log2(vals.size()))+1;

github-actions · 2025-01-16T23:07:57Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+double rmq(int start, int finish, std::vector<std::vector<double>> sparse_table, Comparator comp) {
+    int K = static_cast<int>(std::log2(finish - start + 1));


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(finish - start + 1));

int const K = static_cast<int>(std::log2(finish - start + 1));

github-actions · 2025-01-16T23:07:57Z

task_05/src/test.cpp

-TEST(TopologySort, Simple) {
-  ASSERT_EQ(1, 1);  // Stack []
+TEST(RMQ, Simple) {
+  double expected = 2;


warning: variable 'expected' of type 'double' can be declared 'const' [misc-const-correctness]

Suggested change

double expected = 2;

double const expected = 2;

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-16T23:10:45Z

lib/src/util.cpp

@@ -1 +1,45 @@
 #include "util.hpp"
+
+EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {


warning: the parameter 'edges' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

lib/src/util.hpp:12:

- EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges); + EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges);

Suggested change

EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {

EdgeOrientedGraph::EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges) {

github-actions · 2025-01-16T23:10:46Z

lib/src/util.cpp

+
+EdgeOrientedGraph::EdgeOrientedGraph(EdgeOrientedGraph const& graph) : _ways(graph._ways) {}
+
+int EdgeOrientedGraph::size() { return _ways.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int EdgeOrientedGraph::size() { return _ways.size(); } ^

github-actions · 2025-01-16T23:10:46Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int V = weights.size(); ^

github-actions · 2025-01-16T23:10:46Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: variable 'V' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int V = weights.size();

int const V = weights.size();

github-actions · 2025-01-16T23:10:46Z

lib/src/util.cpp

+        x.pop_back();
+}
+
+int OrientedWeightedGraph::size() { return _weights.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int OrientedWeightedGraph::size() { return _weights.size(); } ^

github-actions · 2025-01-16T23:10:47Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+double rmq(int start, int finish, std::vector<std::vector<double>> sparse_table, Comparator comp) {
+    int K = static_cast<int>(std::log2(finish - start + 1));


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(finish - start + 1));

int const K = static_cast<int>(std::log2(finish - start + 1));

github-actions · 2025-01-16T23:10:47Z

task_05/src/test.cpp


-TEST(TopologySort, Simple) {
+TEST(RMQ, Simple) {
+  // double expected = 2;


warning: variable 'expected' of type 'double' can be declared 'const' [misc-const-correctness]

Suggested change

// double expected = 2;

double const expected = 2;

github-actions · 2025-01-16T23:10:47Z

task_05/src/test.cpp

+TEST(RMQ, Simple) {
+  // double expected = 2;
+  //                         //  0  1  2  3  4  5  6  7  8  9 
+  // std::vector<double> vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};


warning: variable 'vals' of type 'std::vector' can be declared 'const' [misc-const-correctness]

Suggested change

// std::vector<double> vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};

std::vector<double> const vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};

github-actions · 2025-01-16T23:10:48Z

task_05/src/test.cpp

+  // double expected = 2;
+  //                         //  0  1  2  3  4  5  6  7  8  9 
+  // std::vector<double> vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};
+  // std::vector<std::vector<double>> result = sparse_table(vals, 


warning: variable 'result' of type 'std::vector<std::vector>' can be declared 'const' [misc-const-correctness]

Suggested change

// std::vector<std::vector<double>> result = sparse_table(vals,

std::vector<std::vector<double>> const result = sparse_table(vals,

github-actions · 2025-01-16T23:10:48Z

task_05/src/test.cpp

+  // std::vector<double> vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};
+  // std::vector<std::vector<double>> result = sparse_table(vals, 
+  //                                                 std::less<double>());
+  // double num = rmq(1, 6, res, std::less<double>());


warning: use of undeclared identifier 'res' [clang-diagnostic-error]

double num = rmq(1, 6, res, std::less<double>()); ^

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-16T23:11:28Z

lib/src/util.cpp

@@ -1 +1,45 @@
 #include "util.hpp"
+
+EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {


warning: the parameter 'edges' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

lib/src/util.hpp:12:

- EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges); + EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges);

Suggested change

EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {

EdgeOrientedGraph::EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges) {

github-actions · 2025-01-16T23:11:28Z

lib/src/util.cpp

+
+EdgeOrientedGraph::EdgeOrientedGraph(EdgeOrientedGraph const& graph) : _ways(graph._ways) {}
+
+int EdgeOrientedGraph::size() { return _ways.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int EdgeOrientedGraph::size() { return _ways.size(); } ^

github-actions · 2025-01-16T23:11:29Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int V = weights.size(); ^

github-actions · 2025-01-16T23:11:29Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: variable 'V' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int V = weights.size();

int const V = weights.size();

github-actions · 2025-01-16T23:11:29Z

lib/src/util.cpp

+        x.pop_back();
+}
+
+int OrientedWeightedGraph::size() { return _weights.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int OrientedWeightedGraph::size() { return _weights.size(); } ^

github-actions · 2025-01-16T23:11:29Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) {
+    int K = static_cast<int>(std::log2(vals.size()))+1;


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(vals.size()))+1;

int const K = static_cast<int>(std::log2(vals.size()))+1;

github-actions · 2025-01-16T23:11:30Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+double rmq(int start, int finish, std::vector<std::vector<double>> sparse_table, Comparator comp) {
+    int K = static_cast<int>(std::log2(finish - start + 1));


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(finish - start + 1));

int const K = static_cast<int>(std::log2(finish - start + 1));

github-actions · 2025-01-16T23:11:30Z

task_05/src/test.cpp


-TEST(TopologySort, Simple) {
+TEST(RMQ, Simple) {
+  // double expected = 2;


warning: variable 'expected' of type 'double' can be declared 'const' [misc-const-correctness]

Suggested change

// double expected = 2;

double const expected = 2;

github-actions · 2025-01-16T23:11:30Z

task_05/src/test.cpp

+TEST(RMQ, Simple) {
+  // double expected = 2;
+  //                         //  0  1  2  3  4  5  6  7  8  9 
+  // std::vector<double> vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};


warning: variable 'vals' of type 'std::vector' can be declared 'const' [misc-const-correctness]

Suggested change

// std::vector<double> vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};

std::vector<double> const vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};

github-actions · 2025-01-16T23:11:30Z

task_05/src/test.cpp

+  // double expected = 2;
+  //                         //  0  1  2  3  4  5  6  7  8  9 
+  // std::vector<double> vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};
+  // std::vector<std::vector<double>> result = sparse_table(vals, 


warning: variable 'result' of type 'std::vector<std::vector>' can be declared 'const' [misc-const-correctness]

Suggested change

// std::vector<std::vector<double>> result = sparse_table(vals,

std::vector<std::vector<double>> const result = sparse_table(vals,

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-16T23:11:42Z

lib/src/util.cpp

@@ -1 +1,45 @@
 #include "util.hpp"
+
+EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {


warning: the parameter 'edges' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

lib/src/util.hpp:12:

- EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges); + EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges);

Suggested change

EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {

EdgeOrientedGraph::EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges) {

github-actions · 2025-01-16T23:11:42Z

lib/src/util.cpp

+
+EdgeOrientedGraph::EdgeOrientedGraph(EdgeOrientedGraph const& graph) : _ways(graph._ways) {}
+
+int EdgeOrientedGraph::size() { return _ways.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int EdgeOrientedGraph::size() { return _ways.size(); } ^

github-actions · 2025-01-16T23:11:42Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int V = weights.size(); ^

github-actions · 2025-01-16T23:11:42Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: variable 'V' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int V = weights.size();

int const V = weights.size();

github-actions · 2025-01-16T23:11:43Z

lib/src/util.cpp

+        x.pop_back();
+}
+
+int OrientedWeightedGraph::size() { return _weights.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int OrientedWeightedGraph::size() { return _weights.size(); } ^

github-actions · 2025-01-16T23:11:43Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) {
+    int K = static_cast<int>(std::log2(vals.size()))+1;


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(vals.size()))+1;

int const K = static_cast<int>(std::log2(vals.size()))+1;

github-actions · 2025-01-16T23:11:43Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+double rmq(int start, int finish, std::vector<std::vector<double>> sparse_table, Comparator comp) {
+    int K = static_cast<int>(std::log2(finish - start + 1));


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(finish - start + 1));

int const K = static_cast<int>(std::log2(finish - start + 1));

github-actions · 2025-01-16T23:11:43Z

task_05/src/test.cpp


-TEST(TopologySort, Simple) {
+TEST(RMQ, Simple) {
+  // double expected = 2;


warning: variable 'expected' of type 'double' can be declared 'const' [misc-const-correctness]

Suggested change

// double expected = 2;

double const expected = 2;

github-actions · 2025-01-16T23:11:43Z

task_05/src/test.cpp

+TEST(RMQ, Simple) {
+  // double expected = 2;
+  //                         //  0  1  2  3  4  5  6  7  8  9 
+  // std::vector<double> vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};


warning: variable 'vals' of type 'std::vector' can be declared 'const' [misc-const-correctness]

Suggested change

// std::vector<double> vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};

std::vector<double> const vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};

github-actions · 2025-01-16T23:11:44Z

task_05/src/test.cpp

+  // double expected = 2;
+  //                         //  0  1  2  3  4  5  6  7  8  9 
+  // std::vector<double> vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};
+  // std::vector<std::vector<double>> result = sparse_table(vals, 


warning: variable 'result' of type 'std::vector<std::vector>' can be declared 'const' [misc-const-correctness]

Suggested change

// std::vector<std::vector<double>> result = sparse_table(vals,

std::vector<std::vector<double>> const result = sparse_table(vals,

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-16T23:12:36Z

lib/src/util.cpp

@@ -1 +1,45 @@
 #include "util.hpp"
+
+EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {


warning: the parameter 'edges' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

lib/src/util.hpp:12:

- EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges); + EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges);

Suggested change

EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {

EdgeOrientedGraph::EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges) {

github-actions · 2025-01-16T23:12:37Z

lib/src/util.cpp

+
+EdgeOrientedGraph::EdgeOrientedGraph(EdgeOrientedGraph const& graph) : _ways(graph._ways) {}
+
+int EdgeOrientedGraph::size() { return _ways.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int EdgeOrientedGraph::size() { return _ways.size(); } ^

github-actions · 2025-01-16T23:12:37Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int V = weights.size(); ^

github-actions · 2025-01-16T23:12:37Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: variable 'V' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int V = weights.size();

int const V = weights.size();

github-actions · 2025-01-16T23:12:37Z

lib/src/util.cpp

+        x.pop_back();
+}
+
+int OrientedWeightedGraph::size() { return _weights.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int OrientedWeightedGraph::size() { return _weights.size(); } ^

github-actions · 2025-01-16T23:12:37Z

task_03/src/bell_john.cpp

+
+std::vector<double> dijkstra(OrientedWeightedGraph graph, int from_key)
+{
+    double infinity = std::numeric_limits<double>::infinity();


warning: variable 'infinity' of type 'double' can be declared 'const' [misc-const-correctness]

Suggested change

double infinity = std::numeric_limits<double>::infinity();

double const infinity = std::numeric_limits<double>::infinity();

github-actions · 2025-01-16T23:12:37Z

task_05/src/rmq.hpp

+#include <cmath>
+
+template<class Comparator>
+std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) {


warning: the parameter 'vals' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) { ^

github-actions · 2025-01-16T23:12:37Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) {
+    int K = static_cast<int>(std::log2(vals.size()))+1;


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(vals.size()))+1;

int const K = static_cast<int>(std::log2(vals.size()))+1;

github-actions · 2025-01-16T23:12:37Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+double rmq(int start, int finish, std::vector<std::vector<double>> sparse_table, Comparator comp) {
+    int K = static_cast<int>(std::log2(finish - start + 1));


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(finish - start + 1));

int const K = static_cast<int>(std::log2(finish - start + 1));

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-16T23:13:42Z

lib/src/util.cpp

@@ -1 +1,45 @@
 #include "util.hpp"
+
+EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {


warning: the parameter 'edges' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

lib/src/util.hpp:12:

- EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges); + EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges);

Suggested change

EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {

EdgeOrientedGraph::EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges) {

github-actions · 2025-01-16T23:13:43Z

lib/src/util.cpp

+
+EdgeOrientedGraph::EdgeOrientedGraph(EdgeOrientedGraph const& graph) : _ways(graph._ways) {}
+
+int EdgeOrientedGraph::size() { return _ways.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int EdgeOrientedGraph::size() { return _ways.size(); } ^

github-actions · 2025-01-16T23:13:43Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int V = weights.size(); ^

github-actions · 2025-01-16T23:13:43Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: variable 'V' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int V = weights.size();

int const V = weights.size();

github-actions · 2025-01-16T23:13:43Z

lib/src/util.cpp

+        x.pop_back();
+}
+
+int OrientedWeightedGraph::size() { return _weights.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int OrientedWeightedGraph::size() { return _weights.size(); } ^

github-actions · 2025-01-16T23:13:43Z

task_03/src/bell_john.cpp

+
+std::vector<double> dijkstra(OrientedWeightedGraph graph, int from_key)
+{
+    double infinity = std::numeric_limits<double>::infinity();


warning: variable 'infinity' of type 'double' can be declared 'const' [misc-const-correctness]

Suggested change

double infinity = std::numeric_limits<double>::infinity();

double const infinity = std::numeric_limits<double>::infinity();

github-actions · 2025-01-16T23:13:43Z

task_05/src/rmq.hpp

+#include <cmath>
+
+template<class Comparator>
+std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) {


warning: the parameter 'vals' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) { ^

github-actions · 2025-01-16T23:13:43Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) {
+    int K = static_cast<int>(std::log2(vals.size()))+1;


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(vals.size()))+1;

int const K = static_cast<int>(std::log2(vals.size()))+1;

github-actions · 2025-01-16T23:13:44Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+double rmq(int start, int finish, std::vector<std::vector<double>> sparse_table, Comparator comp) {
+    int K = static_cast<int>(std::log2(finish - start + 1));


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(finish - start + 1));

int const K = static_cast<int>(std::log2(finish - start + 1));

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-16T23:14:10Z

lib/src/util.cpp

@@ -1 +1,45 @@
 #include "util.hpp"
+
+EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {


warning: the parameter 'edges' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

lib/src/util.hpp:12:

- EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges); + EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges);

Suggested change

EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {

EdgeOrientedGraph::EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges) {

github-actions · 2025-01-16T23:14:11Z

lib/src/util.cpp

+
+EdgeOrientedGraph::EdgeOrientedGraph(EdgeOrientedGraph const& graph) : _ways(graph._ways) {}
+
+int EdgeOrientedGraph::size() { return _ways.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int EdgeOrientedGraph::size() { return _ways.size(); } ^

github-actions · 2025-01-16T23:14:11Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int V = weights.size(); ^

github-actions · 2025-01-16T23:14:11Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: variable 'V' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int V = weights.size();

int const V = weights.size();

github-actions · 2025-01-16T23:14:11Z

lib/src/util.cpp

+        x.pop_back();
+}
+
+int OrientedWeightedGraph::size() { return _weights.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int OrientedWeightedGraph::size() { return _weights.size(); } ^

github-actions · 2025-01-16T23:14:11Z

task_03/src/bell_john.cpp

+
+std::vector<double> dijkstra(OrientedWeightedGraph graph, int from_key)
+{
+    double infinity = std::numeric_limits<double>::infinity();


warning: variable 'infinity' of type 'double' can be declared 'const' [misc-const-correctness]

Suggested change

double infinity = std::numeric_limits<double>::infinity();

double const infinity = std::numeric_limits<double>::infinity();

github-actions · 2025-01-16T23:14:11Z

task_05/src/rmq.hpp

+#include <cmath>
+
+template<class Comparator>
+std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) {


warning: the parameter 'vals' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) { ^

github-actions · 2025-01-16T23:14:11Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) {
+    int K = static_cast<int>(std::log2(vals.size()))+1;


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(vals.size()))+1;

int const K = static_cast<int>(std::log2(vals.size()))+1;

github-actions · 2025-01-16T23:14:12Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+double rmq(int start, int finish, std::vector<std::vector<double>> sparse_table, Comparator comp) {
+    int K = static_cast<int>(std::log2(finish - start + 1));


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(finish - start + 1));

int const K = static_cast<int>(std::log2(finish - start + 1));

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-16T23:14:22Z

lib/src/util.cpp

@@ -1 +1,45 @@
 #include "util.hpp"
+
+EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {


warning: the parameter 'edges' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

lib/src/util.hpp:12:

- EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges); + EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges);

Suggested change

EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {

EdgeOrientedGraph::EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges) {

github-actions · 2025-01-16T23:14:22Z

lib/src/util.cpp

+
+EdgeOrientedGraph::EdgeOrientedGraph(EdgeOrientedGraph const& graph) : _ways(graph._ways) {}
+
+int EdgeOrientedGraph::size() { return _ways.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int EdgeOrientedGraph::size() { return _ways.size(); } ^

github-actions · 2025-01-16T23:14:22Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int V = weights.size(); ^

github-actions · 2025-01-16T23:14:22Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: variable 'V' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int V = weights.size();

int const V = weights.size();

github-actions · 2025-01-16T23:14:22Z

lib/src/util.cpp

+        x.pop_back();
+}
+
+int OrientedWeightedGraph::size() { return _weights.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int OrientedWeightedGraph::size() { return _weights.size(); } ^

github-actions · 2025-01-16T23:14:23Z

task_03/src/bell_john.cpp

+
+std::vector<double> dijkstra(OrientedWeightedGraph graph, int from_key)
+{
+    double infinity = std::numeric_limits<double>::infinity();


warning: variable 'infinity' of type 'double' can be declared 'const' [misc-const-correctness]

Suggested change

double infinity = std::numeric_limits<double>::infinity();

double const infinity = std::numeric_limits<double>::infinity();

github-actions · 2025-01-16T23:14:23Z

task_05/src/rmq.hpp

+#include <cmath>
+
+template<class Comparator>
+std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) {


warning: the parameter 'vals' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) { ^

github-actions · 2025-01-16T23:14:23Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) {
+    int K = static_cast<int>(std::log2(vals.size()))+1;


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(vals.size()))+1;

int const K = static_cast<int>(std::log2(vals.size()))+1;

github-actions · 2025-01-16T23:14:23Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+double rmq(int start, int finish, std::vector<std::vector<double>> sparse_table, Comparator comp) {
+    int K = static_cast<int>(std::log2(finish - start + 1));


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(finish - start + 1));

int const K = static_cast<int>(std::log2(finish - start + 1));

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-16T23:15:00Z

lib/src/util.cpp

@@ -1 +1,45 @@
 #include "util.hpp"
+
+EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {


warning: the parameter 'edges' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

lib/src/util.hpp:12:

- EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges); + EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges);

Suggested change

EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {

EdgeOrientedGraph::EdgeOrientedGraph(int V, const std::vector<std::vector<int>>& edges) {

github-actions · 2025-01-16T23:15:00Z

lib/src/util.cpp

+
+EdgeOrientedGraph::EdgeOrientedGraph(EdgeOrientedGraph const& graph) : _ways(graph._ways) {}
+
+int EdgeOrientedGraph::size() { return _ways.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int EdgeOrientedGraph::size() { return _ways.size(); } ^

github-actions · 2025-01-16T23:15:00Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int V = weights.size(); ^

github-actions · 2025-01-16T23:15:00Z

lib/src/util.cpp

+}
+
+OrientedWeightedGraph::OrientedWeightedGraph(std::vector<std::vector<double>> const& weights) : _weights(weights) {
+    int V = weights.size();


warning: variable 'V' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int V = weights.size();

int const V = weights.size();

github-actions · 2025-01-16T23:15:00Z

lib/src/util.cpp

+        x.pop_back();
+}
+
+int OrientedWeightedGraph::size() { return _weights.size(); }


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int OrientedWeightedGraph::size() { return _weights.size(); } ^

github-actions · 2025-01-16T23:15:01Z

task_03/src/bell_john.cpp

+
+std::vector<double> dijkstra(OrientedWeightedGraph graph, int from_key)
+{
+    double infinity = std::numeric_limits<double>::infinity();


warning: variable 'infinity' of type 'double' can be declared 'const' [misc-const-correctness]

Suggested change

double infinity = std::numeric_limits<double>::infinity();

double const infinity = std::numeric_limits<double>::infinity();

github-actions · 2025-01-16T23:15:01Z

task_05/src/rmq.hpp

+#include <cmath>
+
+template<class Comparator>
+std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) {


warning: the parameter 'vals' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) { ^

github-actions · 2025-01-16T23:15:01Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+std::vector<std::vector<double>> sparse_table(std::vector<double> vals, Comparator comp) {
+    int K = static_cast<int>(std::log2(vals.size()))+1;


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(vals.size()))+1;

int const K = static_cast<int>(std::log2(vals.size()))+1;

github-actions · 2025-01-16T23:15:01Z

task_05/src/rmq.hpp

+
+template<class Comparator>
+double rmq(int start, int finish, std::vector<std::vector<double>> sparse_table, Comparator comp) {
+    int K = static_cast<int>(std::log2(finish - start + 1));


warning: variable 'K' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int K = static_cast<int>(std::log2(finish - start + 1));

int const K = static_cast<int>(std::log2(finish - start + 1));

MoxDevl and others added 4 commits January 16, 2025 22:45

No tests

6f34eb7

Update util.cpp

7544e3b

Update util.cpp

43482b2

Update util.hpp

d2dbb72

github-actions bot reviewed Jan 16, 2025

View reviewed changes

Deleted default argument

c25e7f0

github-actions bot reviewed Jan 16, 2025

View reviewed changes

Put dijkstra inside of the task 03

6617e58

github-actions bot reviewed Jan 16, 2025

View reviewed changes

Removed repeating declaration

82e9026

github-actions bot reviewed Jan 16, 2025

View reviewed changes

AlgorithmsDafeMipt2024 deleted a comment from github-actions bot Jan 16, 2025

LostPointer reviewed Jan 16, 2025

View reviewed changes

Added tests

b1831de

github-actions bot reviewed Jan 16, 2025

View reviewed changes

MoxDevl added 4 commits January 17, 2025 02:08

Update test.cpp

8b5a587

Update test.cpp

c4c2d35

Update test.cpp

4364080

Update test.cpp

79ce8b3

github-actions bot reviewed Jan 16, 2025

View reviewed changes

Update test.cpp

ee0c8bb

github-actions bot reviewed Jan 16, 2025

View reviewed changes

MoxDevl added 3 commits January 17, 2025 02:11

Update test.cpp

db481ef

Update test.cpp

567f174

Update test.cpp

868c2fd

github-actions bot reviewed Jan 16, 2025

View reviewed changes

		@@ -1 +1,45 @@
		#include "util.hpp"

		EdgeOrientedGraph::EdgeOrientedGraph(int V, std::vector<std::vector<int>> edges) {

		@@ -0,0 +1,33 @@
		#include "topo.hpp"

		void topo_recr(EdgeOrientedGraph& graph, std::stack<int>& vstack, std::vector<int>& vcolor, int current) {


		EdgeOrientedGraph::EdgeOrientedGraph(EdgeOrientedGraph const& graph) : _ways(graph._ways) {}

		int EdgeOrientedGraph::size() { return _ways.size(); }

	double inf = std::numeric_limits<double>::infinity();
	double const inf = std::numeric_limits<double>::infinity();

	int K = static_cast<int>(std::log2(vals.size()))+1;
	int const K = static_cast<int>(std::log2(vals.size()))+1;

	int K = static_cast<int>(std::log2(finish - start + 1));
	int const K = static_cast<int>(std::log2(finish - start + 1));

	// std::vector<double> vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};
	std::vector<double> const vals = {3, 8, 6, 4, 2, 5, 9, 0, 7, 1};

	// std::vector<std::vector<double>> result = sparse_table(vals,
	std::vector<std::vector<double>> const result = sparse_table(vals,

	double infinity = std::numeric_limits<double>::infinity();
	double const infinity = std::numeric_limits<double>::infinity();

Kulikov Maksimilian #35

Are you sure you want to change the base?

Kulikov Maksimilian #35

Uh oh!

Conversation

MoxDevl commented Jan 16, 2025

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

LostPointer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LostPointer Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

LostPointer Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

LostPointer left a comment •

edited

Loading