Graph class ~/lib/src #5
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
task_01/src/test.cpp
Outdated
| TEST(Test, Simple) { | ||
| ASSERT_EQ(1, 1); // Stack [] | ||
| #include "../lib/src/graph.h" | ||
| #include "./main.cpp" |
There was a problem hiding this comment.
warning: suspicious #include of file with '.cpp' extension [bugprone-suspicious-include]
#include "./main.cpp"
^
lib/src/graph.h
Outdated
| @@ -0,0 +1,74 @@ | |||
| #ifndef __GRAPH_H__ | |||
| #define __GRAPH_H__ | |||
There was a problem hiding this comment.
warning: declaration uses identifier 'GRAPH_H', which is a reserved identifier [bugprone-reserved-identifier]
| #define __GRAPH_H__ | |
| #define GRAPH_H_ |
task_01/src/main.cpp
Outdated
| st.push(start_name); | ||
|
|
||
| while (!st.empty()) { | ||
| int v = st.top(); |
There was a problem hiding this comment.
warning: variable 'v' of type 'int' can be declared 'const' [misc-const-correctness]
| int v = st.top(); | |
| int const v = st.top(); |
task_01/src/test.cpp
Outdated
| bool found_parent; | ||
| for (int i = 0; i < order.size(); ++i) { | ||
| for (int j = i + 1; j < order.size(); ++j) { | ||
| found_parent = false; |
There was a problem hiding this comment.
warning: Value stored to 'found_parent' is never read [clang-analyzer-deadcode.DeadStores]
found_parent = false;
^Additional context
task_01/src/test.cpp:9: Value stored to 'found_parent' is never read
found_parent = false;
^
task_01/src/test.cpp
Outdated
| TEST(Test, Simple) { | ||
| ASSERT_EQ(1, 1); // Stack [] | ||
| #include "../../lib/src/graph.h" | ||
| #include "main.cpp" |
There was a problem hiding this comment.
warning: suspicious #include of file with '.cpp' extension [bugprone-suspicious-include]
#include "main.cpp"
^
task_01/src/test.cpp
Outdated
| #include <stdexcept> | ||
|
|
||
| #include "../../lib/src/graph.h" | ||
| #include "main.cpp" |
There was a problem hiding this comment.
warning: suspicious #include of file with '.cpp' extension [bugprone-suspicious-include]
#include "main.cpp"
^
|
|
||
| try { | ||
| topological_sort_dfs_rec(g); | ||
| } catch (std::runtime_error) { |
There was a problem hiding this comment.
warning: catch handler catches by value; should catch by reference instead [misc-throw-by-value-catch-by-reference]
} catch (std::runtime_error) {
^|
|
||
| try { | ||
| topological_sort_dfs_rec(g); | ||
| } catch (std::runtime_error) { |
There was a problem hiding this comment.
warning: catch handler catches by value; should catch by reference instead [misc-throw-by-value-catch-by-reference]
} catch (std::runtime_error) {
^
task_04/src/test.cpp
Outdated
| {{5, 4}, 9}, | ||
| {{4, 5}, 9}, | ||
| }); | ||
| bool passed = (std::map<int, double>( |
There was a problem hiding this comment.
warning: variable 'passed' of type 'bool' can be declared 'const' [misc-const-correctness]
| bool passed = (std::map<int, double>( | |
| bool const passed = (std::map<int, double>( |
|
|
||
| try { | ||
| topological_sort_dfs_rec(g); | ||
| } catch (std::runtime_error) { |
There was a problem hiding this comment.
warning: catch handler catches by value; should catch by reference instead [misc-throw-by-value-catch-by-reference]
} catch (std::runtime_error) {
^|
|
||
| try { | ||
| topological_sort_dfs_rec(g); | ||
| } catch (std::runtime_error) { |
There was a problem hiding this comment.
warning: catch handler catches by value; should catch by reference instead [misc-throw-by-value-catch-by-reference]
} catch (std::runtime_error) {
^| visited[v] = true; | ||
| tin[v] = fup[v] = time++; | ||
| for (size_t i = 0; i < g.adjacents[v].size(); ++i) { | ||
| int to = g.adjacents[v][i].name; |
There was a problem hiding this comment.
warning: variable 'to' of type 'int' can be declared 'const' [misc-const-correctness]
| int to = g.adjacents[v][i].name; | |
| int const to = g.adjacents[v][i].name; |
| } | ||
|
|
||
| std::vector<std::pair<int, int>> get_bridges_taryan(Graph& g) { | ||
| int time = 0; |
There was a problem hiding this comment.
warning: variable 'time' of type 'int' can be declared 'const' [misc-const-correctness]
| int time = 0; | |
| int const time = 0; |
| } | ||
|
|
||
| std::vector<int> get_cut_verts_taryan(Graph& g) { | ||
| int time = 0; |
There was a problem hiding this comment.
warning: variable 'time' of type 'int' can be declared 'const' [misc-const-correctness]
| int time = 0; | |
| int const time = 0; |
| #include <vector> | ||
|
|
||
| class Graph { | ||
| struct vert_neigh { |
|
|
||
| int size() const { return adjacents.size(); } | ||
|
|
||
| void add_vert() { adjacents.push_back({}); } |
There was a problem hiding this comment.
имена методов не по кодстайлу
|
|
||
| bool error_occured = false; | ||
|
|
||
| try { |
There was a problem hiding this comment.
есть ASSERT_THROW и другие похожие макросы
|
|
||
| try { | ||
| topological_sort_dfs_rec(g); | ||
| } catch (std::runtime_error) { |
|
|
||
| #include "../../lib/src/graph.h" | ||
|
|
||
| std::vector<int>* topological_sort_dfs_rec(Graph& g); |
| } | ||
| } | ||
| return dists; | ||
| } |
There was a problem hiding this comment.
утечет то что хранится в top_order(((
Simple class performing the functions of a directed graph with path lengths and point names/