Alexander_homework #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 21, 2024 10:18
LightAboveFighter
force-pushed
the
task_01
branch
from
26b2d5c to
c38b4cb
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,49 @@ | |||
| #ifndef __TOPOLOG_SORT_H__ | |||
| #define __TOPOLOG_SORT_H__ | |||
There was a problem hiding this comment.
warning: declaration uses identifier 'TOPOLOG_SORT_H', which is a reserved identifier [bugprone-reserved-identifier]
Suggested change
| #define __TOPOLOG_SORT_H__ | |
| #define TOPOLOG_SORT_H_ |
| @@ -0,0 +1,49 @@ | |||
| #ifndef __TOPOLOG_SORT_H__ | |||
| #define __TOPOLOG_SORT_H__ | |||
There was a problem hiding this comment.
warning: declaration uses identifier 'TOPOLOG_SORT_H', which is a reserved identifier [bugprone-reserved-identifier]
Suggested change
| #define __TOPOLOG_SORT_H__ | |
| #define TOPOLOG_SORT_H_ |
LostPointer
requested changes
Jan 15, 2025
| add_paths(links); | ||
| } | ||
|
|
||
| Node<T, NameType>* find_via_name(NameType name) { |
There was a problem hiding this comment.
FindByName по кодстайлу
| template <typename T> | ||
| Graph<T, int>& topological_sort(Graph<T, int>& g) { | ||
| std::vector<Node<T, int>*> marked_points; | ||
| for (auto i : g.nodes) { |
There was a problem hiding this comment.
(auto node : g.nodes)
а ещё лучше node_ptr так понятнее будет что там указатель)
There was a problem hiding this comment.
к сожалению эот класс я позже полностью поменял из за нехватки времени, но на будущее учту, спасибо)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.