Consolidate duplicate test execution instructions in AGENTS.md#5
Consolidate duplicate test execution instructions in AGENTS.md#5perNyfelt merged 3 commits intobuild_platformfrom
Conversation
Co-authored-by: perNyfelt <13261538+perNyfelt@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR attempts to consolidate duplicate test execution instructions in AGENTS.md by removing redundancy from the Implementation Guidelines section and adding a new instruction to the Testing Guidelines section. While the removal of the duplicate at line 36 is beneficial, the consolidation inadvertently creates a new redundancy by adding line 26 adjacent to line 25, both of which instruct developers to run tests at similar points in their workflow.
Key changes:
- Added "Always run
./gradlew testafter completing a task to validate changes" to Testing Guidelines (line 26) - Removed duplicate instruction from Implementation Guidelines section (formerly line 36)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - JUnit Jupiter is configured; place specs under `module/src/test/groovy` with `*Test.groovy` naming. | ||
| - Keep UI-heavy code factored so logic can be unit-tested without displays; use resource fixtures already present for rendering assertions. | ||
| - Run `./gradlew test` before pushing; add focused tests when altering IO, clipboard, or rendering behaviors. | ||
| - Always run `./gradlew test` after completing a task to validate changes. |
There was a problem hiding this comment.
This new instruction creates redundancy with line 25. Line 25 already instructs developers to "Run ./gradlew test before pushing", which implicitly covers running tests after completing a task. Having both lines 25 and 26 provides two nearly identical instructions in adjacent lines within the same section. Consider removing this line to keep the Testing Guidelines section concise, as the guidance is already covered by the "before pushing" instruction on line 25.
| - Always run `./gradlew test` after completing a task to validate changes. |
The reviewer identified three redundant statements about running
./gradlew testacross lines 25, 26, and 36 in AGENTS.md.Changes
./gradlew testafter completing a task to validate changes" — merges intent from both duplicates./gradlew testwhen a task is finished to validate changes" — eliminates redundancyResult: Two distinct, non-overlapping instructions remain:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.