minor bug fix, keep db same from now on#4
Open
MediumSizedDeveloper wants to merge 1 commit intoAllenL8921:mainfrom
Open
minor bug fix, keep db same from now on#4MediumSizedDeveloper wants to merge 1 commit intoAllenL8921:mainfrom
MediumSizedDeveloper wants to merge 1 commit intoAllenL8921:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When adding to cart, item did not appear in cart page, neither did price. Minor logical ignorance in a if statement of add_to_cart_STATIC().
before:
if cart_item:
cart_item.quantity += 1
after:
if cart_item and item:
cart_item.quantity += 1
fix: check if the item to be added is BOTH alr an object of both Cart and Item classes.