Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify zookeeper version #39

Merged
merged 56 commits into from
Jun 11, 2024
Merged

Specify zookeeper version #39

merged 56 commits into from
Jun 11, 2024

Conversation

strtgbb
Copy link
Collaborator

@strtgbb strtgbb commented May 16, 2024

  • Add options and logic to set versions of keeper and zookeeper (done)
  • Add option and logic to switch between keeper and zookeeper clusters (done)
  • Add reusable docker compose files (done)
  • Add 3-node clusters of keeper and zookeeper to those reusable files (done)
  • Point suites to those reusable files as much as possible (in progress)
  • Tests pass locally
  • Tests pass in CICD
  • look for solution to using keeper client with full clickhouse as the keeper binary (minor)
  • review odbc bridge logic
  • run regression with --use-keeper
    https://github.com/Altinity/clickhouse-regression/actions/runs/9389656491/job/25857657624

@strtgbb strtgbb force-pushed the specify-zookeeper-version branch from 3451fd9 to 7033644 Compare May 24, 2024 16:11
@strtgbb strtgbb marked this pull request as ready for review May 24, 2024 21:18
@strtgbb
Copy link
Collaborator Author

strtgbb commented May 24, 2024

The remaining failing tests also fail on main

@strtgbb
Copy link
Collaborator Author

strtgbb commented May 31, 2024

odbc bridge is no longer included in the main binary as of 24.4. I will review the related logic in this PR with that in mind

@strtgbb
Copy link
Collaborator Author

strtgbb commented Jun 5, 2024

Note that the open_instances_permissions function from #25 does not work with nodes that have not been passed to Cluster. This means that cleanup might not be working properly with --use-keeper

@strtgbb strtgbb merged commit 1260a37 into main Jun 11, 2024
0 of 46 checks passed
@strtgbb strtgbb deleted the specify-zookeeper-version branch June 11, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant