fix(flux): repin setup-flux-acr so build-push-image picks up the ACR login fix - #3935
Merged
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sduranc
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3912 fixed
flux --provider=azureon the self-hosted runners, but the fix cannot reach any consumer, becausebuild-push-imageandretag-imagepinsetup-flux-acrby SHA:e095eaais from 2026-06-09 — two months before #3912 landed on 2026-08-20. Neither wrapper'saction.yamlhas been touched since, somainstill carries the pre-fix pin today, and consumers bumping their ownbuild-push-imagedigest (asdialogporten-manifestsdid in #61) get a byte-identical action. This repins both tob0c9762, the commit that carries the fix.Why the renovate PR hasn't done this
#3677 makes the same repin — to
4dc0424, which also contains the fix — but it has been open since 2026-06-11 and is stuck:renovate/stability-daysis PENDING, and renovate re-targets the branch at the newestmainSHA as this repo advances, restarting the timer. A perpetually-activemainmeans that check plausibly never settles. This PR is deliberately narrow — two lines, no workflow digest bumps — so it can be reviewed and merged on its own.Impact today
Altinn/dialogporten-manifestshas had bothPublish Flux artifactsjobs failing since moving to self-hosted runners, with the exact failure from #3912:It is unblocked for now by clearing
IDENTITY_ENDPOINT/MSI_ENDPOINTper job (Altinn/dialogporten-manifests#73, the same workaround as Altinn/info.altinn.no#706). Both of those can be reverted once this lands. Per #3926,flux/build-push-imagehas 8 external consumer repos, so anyone else moving a flux workflow onto these runners hits the same wall until then.Relationship to the dis-way migration
Independent, and this does not conflict with it. dis-way/actions#68 copies these actions under
altinn/, and its copy ofsetup-flux-acralready embeds the #3912 fix — so the bug does not follow consumers to the new home. But that PR and #3926 are both still open, and consumers are on theAltinn/altinn-platformpaths until they migrate. This closes the gap in the meantime.Verification
setup-flux-acr/action.yaml@b0c9762contains theExpose federated credentials to the Azure SDKstep;@e095eaadoes not.b0c9762is the most recent commit touching that file, so this pins the current state of the action rather than an arbitrary intermediate.WorkloadIdentityCredentialsimply resolves before the CLI credential the chain reaches there today, as the same application.🤖 Generated with Claude Code