Skip to content

fix(flux): repin setup-flux-acr so build-push-image picks up the ACR login fix - #3935

Merged
arealmaas merged 2 commits into
mainfrom
arealmaas/repin-setup-flux-acr
Aug 26, 2026
Merged

fix(flux): repin setup-flux-acr so build-push-image picks up the ACR login fix#3935
arealmaas merged 2 commits into
mainfrom
arealmaas/repin-setup-flux-acr

Conversation

@arealmaas

Copy link
Copy Markdown
Contributor

#3912 fixed flux --provider=azure on the self-hosted runners, but the fix cannot reach any consumer, because build-push-image and retag-image pin setup-flux-acr by SHA:

uses: Altinn/altinn-platform/actions/flux/setup-flux-acr@e095eaa67ba630897e9b488a933c8ebb82b36732 # main

e095eaa is from 2026-06-09 — two months before #3912 landed on 2026-08-20. Neither wrapper's action.yaml has been touched since, so main still carries the pre-fix pin today, and consumers bumping their own build-push-image digest (as dialogporten-manifests did in #61) get a byte-identical action. This repins both to b0c9762, the commit that carries the fix.

Why the renovate PR hasn't done this

#3677 makes the same repin — to 4dc0424, which also contains the fix — but it has been open since 2026-06-11 and is stuck: renovate/stability-days is PENDING, and renovate re-targets the branch at the newest main SHA as this repo advances, restarting the timer. A perpetually-active main means that check plausibly never settles. This PR is deliberately narrow — two lines, no workflow digest bumps — so it can be reviewed and merged on its own.

Impact today

Altinn/dialogporten-manifests has had both Publish Flux artifacts jobs failing since moving to self-hosted runners, with the exact failure from #3912:

✗ error during login with provider: ... DefaultAzureCredential: failed to acquire a token
    ManagedIdentityCredential authentication failed.
    GET http://localhost:12356/msi/token
    RESPONSE 400: Unable to load the proper Managed Identity

It is unblocked for now by clearing IDENTITY_ENDPOINT/MSI_ENDPOINT per job (Altinn/dialogporten-manifests#73, the same workaround as Altinn/info.altinn.no#706). Both of those can be reverted once this lands. Per #3926, flux/build-push-image has 8 external consumer repos, so anyone else moving a flux workflow onto these runners hits the same wall until then.

Relationship to the dis-way migration

Independent, and this does not conflict with it. dis-way/actions#68 copies these actions under altinn/, and its copy of setup-flux-acr already embeds the #3912 fix — so the bug does not follow consumers to the new home. But that PR and #3926 are both still open, and consumers are on the Altinn/altinn-platform paths until they migrate. This closes the gap in the meantime.

Verification

  • setup-flux-acr/action.yaml@b0c9762 contains the Expose federated credentials to the Azure SDK step; @e095eaa does not.
  • b0c9762 is the most recent commit touching that file, so this pins the current state of the action rather than an arbitrary intermediate.
  • Diff is two lines, one per wrapper. No behaviour change on GitHub-hosted runners: WorkloadIdentityCredential simply resolves before the CLI credential the chain reaches there today, as the same application.

🤖 Generated with Claude Code

@arealmaas
arealmaas requested a review from a team as a code owner August 25, 2026 13:40
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4dc6592f-333b-4819-83ac-4a55609c2054


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@arealmaas
arealmaas merged commit 523f141 into main Aug 26, 2026
5 checks passed
@arealmaas
arealmaas deleted the arealmaas/repin-setup-flux-acr branch August 26, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants