Skip to content

Fixing two flaky Cypress tests #4324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olemartinorg merged 2 commits into from
Jul 22, 2026
Merged

Fixing two flaky Cypress tests #4324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85e08f9
Fix 1: This test would sometimes fail because the length was 2 alread…
Jul 21, 2026
d0a04c9
Fix 2: This test ran into a failure mode where the whole body would b…
Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions test/e2e/integration/frontend-test/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,10 @@ describe('Options', () => {

cy.goto('changename');

// All options are fetched once at first (with 'undefined' in mapping, as no value for source has been set)
cy.get('@interceptOptions(references).all').should('have.length', 1);
cy.get('@interceptOptions(test).all').should('have.length', 1);

// This field uses preselectedOptionIndex to select 'Altinn'
cy.get(appFrontend.changeOfName.sources).should('have.value', 'Altinn');

// At that point our options have new mappings, so requests should have fired again
// At this point our options have new mappings, so requests should have fired again
cy.get('@interceptOptions(references).all').should('have.length', 2);
cy.get('@interceptOptions(test).all').should('have.length', 2);

Expand Down
8 changes: 8 additions & 0 deletions test/e2e/integration/frontend-test/tabbing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,15 @@ const appFrontend = new AppFrontend();

describe('Tabbing', () => {
it('Tab through the fields in change name form', () => {
cy.intercept('GET', '**/api/options/references?language=nb&source=altinn').as('fetchReferences');
cy.goto('changename');

// Making extra sure we've finished waiting for the page to load. Sometimes, if we start too early (unrealistically
// early, compared to real users) the focus might have been reset before we get to simulate tabbing. This was
// somewhat flaky for a while.
cy.wait('@fetchReferences');
cy.waitUntilSaved();

cy.get(appFrontend.changeOfName.newFirstName).focus().tab();
cy.focused().should('have.text', 'Nytt mellomnavn');
cy.tab();
Expand Down