Skip to content

Conversation

@lonelyicer
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings June 7, 2025 17:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new set of toilet-themed features for the PoopSky mod. The primary changes include adding new toilet blocks (and their lava‐variant counterparts), custom particle effects and mob effects (Fecal Incontinence and Intestinal Spasm), and registering new block entities and item groups to support the updated functionality.

Reviewed Changes

Copilot reviewed 174 out of 174 changed files in this pull request and generated no comments.

Show a summary per file
File Description
PoopParticle.java Implements a custom particle effect for the mod.
PSParticles.java Registers the new poop particle.
PSEffects.java, IntestinalSpasmEffect.java, FecalIncontinenceEffect.java Add new mob effects using updated attribute modifiers and conditional logic.
PSBlockStateProvider.java Adds model registration for new toilet blocks and lava variants using modern switch expressions.
ToiletLavaBlock.java, ToiletBlock.java Implement block behavior for toilet blocks with interactive effects such as turning lava, dropping items, and sound effects.
ToiletBlockEntity.java Registers a new block entity for toilet blocks to store linked state.
ToiletBlocks.java, PSBlocks.java, PSBlockEntities.java, PSItemGroups.java, PoopSky.java Update registration and initialization logic for the new blocks, items, entities, and particle providers.
AbstractToiletBlock.java Provides common functionality for toilet blocks including collision, item drops, and reaction to falling entities.
Comments suppressed due to low confidence (1)

src/main/java/com/altnoir/poopsky/block/AbstractToiletBlock.java:51

  • The condition is using the bitwise OR operator '|' between boolean expressions. To ensure short-circuit evaluation and correct logical behavior, consider replacing '|' with the logical OR operator '||'.
if (entity instanceof FallingBlockEntity falling && falling.getBlockState().is(Blocks.ANVIL) | falling.getBlockState().is(Blocks.CHIPPED_ANVIL) | falling.getBlockState().is(Blocks.DAMAGED_ANVIL)) {

@Altnoir Altnoir merged commit e0020f2 into Altnoir:1.21.1-NeoForge Jun 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants