Skip to content

Conversation

@lonelyicer
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings June 7, 2025 17:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables rotation clamping when a passenger turns, preserving the entity’s natural rotation behavior.

  • Comment out the clampRotation call in onPassengerTurned to stop enforcing rotation limits.
Comments suppressed due to low confidence (1)

src/main/java/com/altnoir/poopsky/entity/p/ToiletPlugEntity.java:467

  • Ensure you add or update unit tests to verify that onPassengerTurned no longer clamps rotation, preventing regressions for this changed behavior.
//this.clampRotation(entityToUpdate);

@lonelyicer lonelyicer merged commit c3e7312 into Altnoir:1.21.1-NeoForge Jun 7, 2025
1 check passed
@lonelyicer lonelyicer deleted the fix/dont-clamp-rotation branch June 7, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant