Skip to content

Conversation

@lonelyicer
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings June 12, 2025 09:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the teleportation sound effect and adjusts its pitch range for the AbstractToiletBlock.

  • Swapped out PLAYER_TELEPORT for MUD_BREAK when players teleport.
  • Changed random pitch offset from 0.5F to 0.1F.
Comments suppressed due to low confidence (1)

src/main/java/com/altnoir/poopsky/block/AbstractToiletBlock.java:145

  • Add a unit or integration test to verify that invoking teleportPlayer results in the MUD_BREAK sound event, ensuring the new behavior is covered.
targetWorld.playSound(null, player.getX(), player.getY() + 0.1, player.getZ(), SoundEvents.MUD_BREAK, SoundSource.PLAYERS, 1.0F, pitch);

@lonelyicer lonelyicer merged commit 2e87552 into Altnoir:1.21.1-NeoForge Jun 12, 2025
1 check passed
@lonelyicer lonelyicer deleted the chore/replace-portal-sound branch June 12, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant