fix: fluid textures didnt register #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes the registration of fluid textures for the poop liquid by adding the missing flowing texture metadata file and implementing proper client-side texture registration through NeoForge's IClientFluidTypeExtensions.
Key changes:
- Added animation metadata for the flowing poop liquid texture
- Refactored
PSFluidTypesfrom extendingFluidTypeto a utility class with static textureResourceLocationfields - Implemented client extension registration to properly bind fluid textures
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| poop_liquid_flowing.png.mcmeta | Added animation metadata for flowing fluid texture with 7 frames at 16x16 resolution |
| poop_liquid_flowing.png | Added the flowing fluid texture image file |
| PSFluidTypes.java | Refactored from extending FluidType to utility class; added static ResourceLocation fields for texture paths |
| PoopSky.java | Added registerClientExtensions event handler to register fluid textures via IClientFluidTypeExtensions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.