feature: otter create brings eslint and version harmonize #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit a4405f0.
☁️ Nx Cloud last updated this comment at |
github-actions
bot
added
enhancement
vscaiceanu-1a
force-pushed
the
feature/schematics-version-harmonize
branch
2 times, most recently
from
fa0e262 to
4ee2482
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files☔ View full report in Codecov by Sentry. |
vscaiceanu-1a
force-pushed
the
feature/schematics-version-harmonize
branch
from
4ee2482 to
e073464
Compare
vscaiceanu-1a
force-pushed
the
feature/schematics-version-harmonize
branch
from
e073464 to
94dad11
Compare
fpaul-1A
reviewed
Feb 13, 2025
fpaul-1A
reviewed
Feb 13, 2025
| const postInstall = rootPackageJsonObject.scripts?.postinstall; | ||
| rootPackageJsonObject.scripts = { | ||
| ...rootPackageJsonObject.scripts, | ||
| harmonize: `eslint '**/package.json*' ${isYarnPackageManager ? '.yarnrc.yml' : ''} --quiet --fix`, |
There was a problem hiding this comment.
I'm not sure how, but we need to find a way to trigger another install after a successful harmonize
currently we have to run the install twice which is not ideal
kpanot
reviewed
Feb 20, 2025
| */ | ||
| const addHarmonizeScript = (): Rule => { | ||
| return (tree: Tree) => { | ||
| const rootPackageJsonPath = '/package.json'; |
There was a problem hiding this comment.
not need to be defined in the function
| } | ||
|
|
||
| return useOtterLinter; | ||
| return !!tree.root.subfiles.some((file) => /\.eslintrc(\.json|\.js|\.yaml|\.yml)?$/.test(file)); |
There was a problem hiding this comment.
Suggested change
| return !!tree.root.subfiles.some((file) => /\.eslintrc(\.json|\.js|\.yaml|\.yml)?$/.test(file)); | |
| return !!tree.root.subfiles.some((file) => /\.eslintrc\.(?:json|js|ya?ml)?$/.test(file)); |
vscaiceanu-1a
force-pushed
the
feature/schematics-version-harmonize
branch
from
94dad11 to
71a6f31
Compare
vscaiceanu-1a
force-pushed
the
feature/schematics-version-harmonize
branch
from
71a6f31 to
a4405f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues