[cascading] from release/12.0 to main #2906
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![otter-cascading[bot]](https://avatars.githubusercontent.com/in/318094?s=60&v=4){kind=small}
## Proposed change Removing `@o3r/eslint-config` explicit dev dep for `@o3r/eslint-plugin` as it comes from its own package json. Fixes the following scenario: - create a new otter project with a fixed version - add `@o3r/eslint-config` (with fixed otter version) Now: version is not fixed for `@o3r/eslint-plugin` Expected: version is fixed for `@o3r/eslint-plugin`
## Proposed change The regex for checking for flat config files was invalid. This code is currently duplicated in workspace and core, is there a place where we can move it so that it can be reused? In schematics maybe?
…er (#2904) Fix/remove deprecated cascading action and jasmine from eslint-config-otter ## Proposed change <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *Pull Request #issue -->
|
covered by |
mrednic-1A
temporarily deployed
to
production
GitHub Actions
Inactive
mrednic-1A
temporarily deployed
to
cascading-app
GitHub Actions
Inactive
mrednic-1A
had a problem deploying
to
production
GitHub Actions
Failure
## Proposed change <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *
matthieu-crouzet
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cascading from release/12.0 to main
❗ The pull request is conflicting with the target branch.
You can fix the issue locally with the following commands:
Using gh CLI
and update this Pull Request with
Using git only
and update this Pull Request with
This Pull Request has been generated with ❤️ by the Otter cascading tool.