Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recommended preset for o3r core schematic #2913

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vscaiceanu-1a
Copy link
Member

Proposed change

Add a default recommended preset for @o3r/core ng add schematic.

  • workspace schematic no longer brings eslint-config as it is brought by core for both project and workspace.
  • it tests setup updated to use the basic preset in order to test the ng-add of eslint (and future packages part of recommended). We may consider having 2 IT setups (one for basic, one for recommended).
  • workspace has flags to skip features (VSCode tools and renovate). For basic preset, the skip flags are passed by the core ng-add.

Copy link

nx-cloud bot commented Feb 27, 2025

View your CI Pipeline Execution ↗ for commit 55e4f14.

Command Status Duration Result
nx run-many --target=test-int ❌ Failed 1h 10m 24s View ↗
nx run-many --target=test-e2e ✅ Succeeded 10m 14s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 2s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 30s View ↗
nx run-many --target=prepare-publish --exclude-... ✅ Succeeded 1m 21s View ↗
nx run-many --target=build,build-swagger ✅ Succeeded 12m 6s View ↗
nx affected --target=test --collectCoverage ✅ Succeeded 59s View ↗
nx affected --target=lint ✅ Succeeded 3m 3s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-02-27 18:28:44 UTC

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.17%. Comparing base (04a4ab4) to head (55e4f14).
Report is 14 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../@o3r/core/schematics/ng-add/utils/linter/index.ts 66.66% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant