Fix Sign In crash and Consultation navigation issues (#316)#317
Open
suryaprakash0010 wants to merge 3 commits intoAmarjha01:masterfrom
Open
Fix Sign In crash and Consultation navigation issues (#316)#317suryaprakash0010 wants to merge 3 commits intoAmarjha01:masterfrom
suryaprakash0010 wants to merge 3 commits intoAmarjha01:masterfrom
Conversation
Author
|
Merge conflicts resolved! I've updated the branch with the required fixes. Please check and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Description
Fixed critical issues in the InfantCareCompass application that were preventing proper functionality:
🔧 Sign In Page Error Fix
Problem: handleGitHubLogin is not defined error crashed the Sign In page when users clicked the GitHub login button
Solution: Implemented the missing SignIn.jsx
function with proper error handling and user-friendly toast notifications
Result: Sign In page now works without crashes and provides clear feedback to users
🛣️ Consultation Navigation Fix
Problem: After visiting the Consultation page, navigation links (Home, About, Blog) stopped working due to routing conflicts
Solution:
Fixed consultation route structure in routes.jsx
with proper nested routing
Corrected duplicate route definitions that caused conflicts
Ensured proper configuration for nested routes
Result: All navigation works seamlessly after visiting Consultation page
🎨 News Page Background Consistency Fix
Problem: News page had inconsistent light background that broke brand identity compared to other pages
Solution:
Updated News page background to match Home page dark theme
Applied glassmorphism card styling for dark theme compatibility
Fixed all text colors for proper contrast on dark background
Result: News page now has consistent dark theme matching entire website
✅ Checklist
My code follows the project's coding guidelines.
I have tested these changes locally.
I have added necessary documentation/comments (if applicable).
I have linked the related issue (if applicable).
🔗 Related Issue
Closes #316 and #315
📸 Screenshots & video (if applicable)
No UI screenshots required as these are code fixes (routing, error handling, and styling)
🎯 Issues Resolved
✅ Sign In authentication flow now works without errors (#316)
✅ Navigation links function properly after visiting Consultation page (#316)
✅ Nested routing for doctor detail pages works correctly (#316)
✅ News page background now consistent with site theme (#315)
🔧 Technical Details
Files Modified:
client/src/pages/SignIn.jsx
(added handleGitHubLogin function)
client/src/routes/routes.jsx
(fixed routing structure)
client/src/pages/consult.jsx
(fixed nested routing)
client/src/pages/News.jsx
(updated background theme and styling)
Testing: All fixes have been validated and work as expected
Backward Compatibility: Changes are fully backward compatible
🚀 Impact
These fixes resolve critical user experience issues that were preventing users from:
Successfully signing into the application
Navigating between pages after using the Consultation feature
Experiencing consistent visual branding across all pages
The application now provides a smooth, error-free, and visually consistent experience for all users! 🎉
📊 Summary
Issues Fixed: #316 (Sign In & Navigation) and #315 (News Background)
Files Changed: 3 files with targeted improvements
User Experience: Significantly improved with no crashes or navigation issues