Proposal: change state override detection #1077
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to do an estimateEOA - if it fails, we mark the chain as unsupported for state override as it doesn't do it properly
borislav-itskov
had a problem deploying
to
tests
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dedicate a special function for checking state override that tries to do an
estimateEOA- if it fails, we mark the chain as unsupported for state override as it doesn't do it properly.Problem: Moonbeam doesn't work.
Moonbeam doesn't work as it supports state override but not fully. Simple state override like putting code to an EVM address works, but putting the Ambire code on an EOA and calling execute() on it doesn't. So both simulations + estimation doesn't work. And the worst of all is that the EOA estimation gets bricked and the user cannot broadcast.